Padding bug mismatch #144
Padding bug mismatch #144
Conversation
CBC with no padding requires input that is an entire block in length. If a different size is provided we should return an error on _final. Signed-off-by: Simo Sorce <[email protected]>
Signed-off-by: Simo Sorce <[email protected]>
There was a problem hiding this comment.
lgtm.
The only though I had is that the decrypt_initialize() and encrypt_initialize() have almost all repeated code so I though if we should factor it out to some crypt_initialize() and use the EVP_CipherInit_ex() and similar functions in here. But I can do it in separate PR if you would find it useful.
I am not against, but it is also minor impact work, so can be done later as needed. |
|
ok. Will make it into an issue so it wont be lost and do it once I will have some time. |
Found while messing with some openssl test code and pkcs11-provider