-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(explorer): handle tuples in interact form #3464
chore(explorer): handle tuples in interact form #3464
Conversation
🦋 Changeset detectedLatest commit: b152d79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey @JamesLefrere , thanks for the contribution, this looks great! We have plans to improve the tuples/arrays support further but this is already very useful. Only issue is that it doesn't seem to work for all tuples, for example |
Ah thanks @karooolis , you're right, looks like we need to make that recursive perhaps and the user could enter |
Yeah good shoutout, a tuple could contain another tuple, and so on. |
...ges/explorer/src/app/(explorer)/[chainName]/worlds/[worldAddress]/interact/FunctionField.tsx
Outdated
Show resolved
Hide resolved
...ges/explorer/src/app/(explorer)/[chainName]/worlds/[worldAddress]/interact/FunctionField.tsx
Outdated
Show resolved
Hide resolved
d7635b9
to
dc3f1c5
Compare
...ges/explorer/src/app/(explorer)/[chainName]/worlds/[worldAddress]/interact/FunctionField.tsx
Outdated
Show resolved
Hide resolved
dc3f1c5
to
63089cb
Compare
8d82958
to
e304d26
Compare
Having implemented recursive handling of tuples I'm thinking next to the function name to not show tuples types but rather the tuple's name. And then inside inputs show the types. Added screenshot for the reference on how it currently looks @JamesLefrere . I'll work on this more tomorrow. |
Fixes #3359 by doing what the user intended and making it clear what to input.