feat(create-mud): rip out create-create-app #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 78e9ed1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
commented
Jan 21, 2025
packages/create-mud/src/bin/cli.ts
Outdated
Comment on lines
50
to
55
| if (/package\.json$/.test(sourceFile)) { | ||
| const source = await fs.readFile(sourceFile, "utf-8"); | ||
| await fs.writeFile(targetFile, source.replaceAll(/{{mud-version}}/g, args.mudVersion), "utf-8"); | ||
| } else { | ||
| await fs.copyFile(sourceFile, targetFile); | ||
| } |
There was a problem hiding this comment.
If we didn't have to do a string replace on specific files, this could be simplified to
fs.cp(sourceDir, targetDir, { recursive: true })
alvrs
previously approved these changes
Jan 21, 2025
holic
force-pushed
the
holic/template-cli
branch
from
d8fc82c to
d252fd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ripped out create-create-app because it's getting in the way of new templates and we were only using it to 1) recursively copy files and 2) inject the MUD version.
I am using yargs-interactive here for now because that's what create-create-mud used, but we can swap this out later for something else that gives us more power or flexibility or better types.
Due to limitations of yargs-interactive, this changes the CLI slightly from
to
where the latter prompts first for the project name, which is arguably a better experience. You can still provide both the name and template as CLI args.
