refactor(store-consumer): adapt WithWorld to be a System #3546
Conversation
🦋 Changeset detectedLatest commit: 46645e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -4,7 +4,7 @@ pragma solidity >=0.8.24; | |||
| // @dev Provides information about the current execution context | |||
| // We only use it in these contracts in case we want to extend it in the future | |||
| abstract contract Context { | |||
| function _msgSender() internal view virtual returns (address) { | |||
| function _msgSender() public view virtual returns (address) { | |||
There was a problem hiding this comment.
because _msgSender in WorldContext.sol is public so we need to be able to override
There was a problem hiding this comment.
for context: it's public to have a unique interface id we can check for in supportsInterface so only contracts that are intended to be used as systems can be registered as systems
|
This means you can use stuff like |
Yeah I think those should work, but also so that you can restrict access to systems within the same namespace. |
vdrg
changed the title
vdrg
force-pushed
the
vdrg/store-consumer-only-world-modifier
branch
from
2bb16a5 to
33f8b2c
Compare
| // We use WorldContextConsumer directly as we already know the world is the caller | ||
| if (!_callerIsWorld() || !ResourceAccess.get(getNamespaceId(), WorldContextConsumer._msgSender())) { |
There was a problem hiding this comment.
so if my EOA has access to the namespace I still have to call the token system through the world correct?
There was a problem hiding this comment.
yeah, I thought about checking for supporting it for both EOAs and world, but I felt it was more consistent this way.
vdrg
force-pushed
the
vdrg/store-consumer-only-world-modifier
branch
from
23af1f9 to
c913341
Compare
vdrg
force-pushed
the
vdrg/store-consumer-only-world-modifier
branch
from
62473ad to
6403c30
Compare
Now
WithWorldis also a System, and we modify theonlyNamespacemodifier so that protected functions can only be called by calling the system through the world.