Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roadie/Backstage docs #89

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Conversation

samnixon87
Copy link
Contributor

Requirements

Intended availability

If you're adding a new integration, let us know if you are a community member or a partner.

  • Partner

If you are a partner, your integration will be available to all customers.

If you're part of the community and submitting an integration for your own purposes or internal teams, specify your company name so that we can verify your identity and enable the integration for your account.

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided

If you're adding a new integration, provide some context into how LaunchDarkly and the third-party service should interact.

  • New integration for Backstage. Uses an LD API token to authenticate calls in order to retrieve feature flags.

If you're modifying an existing integration, provide a clear and concise description of what you expect to happen.

Describe alternatives you've considered

If you're modifying an existing integration, provide a clear and concise description of any alternative solutions or features you've considered.

Provide a request preview

Include the output from running npm run preview <INTEGRATION_NAME>.

Additional context

Add any other context about the pull request here.

@samnixon87 samnixon87 requested review from a team as code owners September 27, 2024 14:05
integrations/roadie/manifest.json Outdated Show resolved Hide resolved
@InTheCloudDan
Copy link
Contributor

@samnixon87 There's one more issue with the run and it doesn't look like I have permissions to push to your branch for this PR. Can you fix the end-of-file for the horizontal.svg

Fix End of Files.........................................................Failed
- hook id: end-of-file-fixer
- duration: 0.08s
- exit code: 1
- files were modified by this hook

Fixing integrations/roadie/assets/images/horizontal.svg

Copy link
Contributor

@InTheCloudDan InTheCloudDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above in PR

Fix for end of line test failure
@samnixon87
Copy link
Contributor Author

@samnixon87 There's one more issue with the run and it doesn't look like I have permissions to push to your branch for this PR. Can you fix the end-of-file for the horizontal.svg

Just pushed a change @InTheCloudDan and the EOL error on the horizontal svg looks like it's been resolved. 👍

Fix to incorrect svg
@InTheCloudDan InTheCloudDan merged commit d9e6781 into launchdarkly:main Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants