Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct documentation for AI config function. #754

Merged
merged 8 commits into from
Jan 24, 2025
Merged

fix: Correct documentation for AI config function. #754

merged 8 commits into from
Jan 24, 2025

Conversation

kinyoklion
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 19014 bytes
Size limit: 21000

@github-actions GitHub Actions
Copy link
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 19826 bytes
Size limit: 21000

@github-actions GitHub Actions
Copy link
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 15354 bytes
Size limit: 20000

@kinyoklion kinyoklion force-pushed the rlamb/fix-ai-config-comments branch 3 times, most recently from 9c80ba0 to f978320 Compare January 23, 2025 23:25
@kinyoklion kinyoklion force-pushed the rlamb/fix-ai-config-comments branch from f978320 to 0a0ffb4 Compare January 23, 2025 23:30
@kinyoklion kinyoklion marked this pull request as ready for review January 23, 2025 23:31
@kinyoklion kinyoklion requested a review from a team as a code owner January 23, 2025 23:31
mmrj
mmrj approved these changes Jan 23, 2025
View reviewed changes
packages/sdk/server-ai/src/api/LDAIClient.ts Outdated Show resolved Hide resolved
cvolawless
cvolawless approved these changes Jan 23, 2025
View reviewed changes
Copy link

@cvolawless cvolawless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM TY

mmrj
mmrj approved these changes Jan 23, 2025
View reviewed changes
packages/sdk/server-ai/src/api/LDAIClient.ts Outdated Show resolved Hide resolved
packages/sdk/server-ai/src/api/LDAIClient.ts Outdated Show resolved Hide resolved
@kinyoklion kinyoklion merged commit 0bdb0be into main Jan 24, 2025
22 checks passed
@kinyoklion kinyoklion deleted the rlamb/fix-ai-config-comments branch January 24, 2025 00:03
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
Merged
kinyoklion pushed a commit that referenced this pull request Jan 24, 2025
@github-actions
chore: release main (#755)
76347d8 
🤖 I have created a release *beep* *boop*
---


<details><summary>server-sdk-ai: 0.8.1</summary>

##
[0.8.1](server-sdk-ai-v0.8.0...server-sdk-ai-v0.8.1)
(2025-01-24)


### Bug Fixes

* Correct documentation for AI config function.
([#754](#754))
([0bdb0be](0bdb0be))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvolawless cvolawless cvolawless approved these changes

@mmrj mmrj mmrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kinyoklion @mmrj @cvolawless