Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update react monorepo to v19 (major) #1505

Merged
merged 6 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .storybook/utils.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import type { Args, Decorator, ReactRenderer } from '@storybook/react';
import type { AnnotatedStoryFn, StoryContext } from '@storybook/types';
import type { JSX } from 'react';

import merge from 'deepmerge';
import { Fragment } from 'react';

Expand Down
16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,15 @@
"@storybook/types": "^8.4.0",
"@testing-library/dom": "^10.4.0",
"@testing-library/jest-dom": "^6.6.2",
"@testing-library/react": "^16.0.0",
"@testing-library/react": "^16.1.0",
"@testing-library/user-event": "^14.5.2",
"@types/css-modules": "^1.0.5",
"@types/node": "^22.10.1",
"@types/react": "^18.3.1",
"@types/react-dom": "^18.3.0",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.1",
"@vanilla-extract/css": "^1.16.0",
"@vanilla-extract/vite-plugin": "^4.0.2",
"@vitejs/plugin-react-swc": "^3.7.0",
"@vitejs/plugin-react-swc": "^3.7.2",
"@vitest/coverage-v8": "^2.1.1",
"@vitest/ui": "^2.1.1",
"browserslist": "^4.24.0",
Expand All @@ -76,8 +76,8 @@
"lint-staged": "^15.2.0",
"nx": "20.0.7",
"plop": "^4.0.0",
"react": "18.3.1",
"react-dom": "18.3.1",
"react": "19.0.0",
"react-dom": "19.0.0",
"react-router-dom": "6.16.0",
"rollup-plugin-pure": "^0.2.1",
"storybook": "^8.4.0",
Expand All @@ -94,9 +94,9 @@
},
"peerDependencyRules": {
"allowedVersions": {
"react": "18",
"react": "19",
"rollup": "4",
"vite": "5"
"vite": "6"
}
}
},
Expand Down
8 changes: 4 additions & 4 deletions packages/alert/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@
"classix": "2.2.0"
},
"peerDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"devDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "19.0.0",
"react-dom": "19.0.0"
}
}
8 changes: 4 additions & 4 deletions packages/avatar/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@
"classix": "2.2.0"
},
"peerDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"devDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "19.0.0",
"react-dom": "19.0.0"
}
}
8 changes: 4 additions & 4 deletions packages/banner/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@
"classix": "2.2.0"
},
"peerDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"devDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "19.0.0",
"react-dom": "19.0.0"
}
}
8 changes: 4 additions & 4 deletions packages/box/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
},
"peerDependencies": {
"@vanilla-extract/css": "^1.14.0",
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"devDependencies": {
"flat": "^6.0.1",
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "19.0.0",
"react-dom": "19.0.0"
}
}
8 changes: 4 additions & 4 deletions packages/button/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@
"classix": "2.2.0"
},
"peerDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"devDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "19.0.0",
"react-dom": "19.0.0"
}
}
8 changes: 7 additions & 1 deletion packages/button/src/Button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { IconProps } from '@launchpad-ui/icons';
import type {
ButtonHTMLAttributes,
ElementType,
JSX,
KeyboardEventHandler,
MouseEvent,
ReactElement,
Expand Down Expand Up @@ -95,7 +96,12 @@ const ButtonComponent = forwardRef<HTMLButtonElement, ButtonProps>((props, ref)

const renderChildren = () => {
if (asChild && isValidElement(children)) {
return cloneElement(children, undefined, getFinalChildren(children.props.children));
return cloneElement(
children,
undefined,
// biome-ignore lint/suspicious/noExplicitAny: <explanation>
getFinalChildren((children as ReactElement<any>).props.children),
);
}

return getFinalChildren(children);
Expand Down
8 changes: 4 additions & 4 deletions packages/card/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@
"classix": "2.2.0"
},
"peerDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"devDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "19.0.0",
"react-dom": "19.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/card/src/RadioCard.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { ReactNode } from 'react';
import type { JSX, ReactNode } from 'react';

import { Radio, type RadioProps } from '@launchpad-ui/form';
import { cx } from 'classix';
Expand Down
6 changes: 3 additions & 3 deletions packages/card/stories/RadioCard.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { StoryFn, StoryObj } from '@storybook/react';
import type { Meta, StoryObj } from '@storybook/react';

import { RadioCard } from '../src/RadioCard';

Expand All @@ -7,7 +7,7 @@ export default {
title: 'Legacy/Deprecated/Card/RadioCard',
description: 'A radio button with a label and optional image and subtext.',
decorators: [
(Story: StoryFn) => (
(Story) => (
<div style={{ display: 'flex', width: '15rem' }}>
<Story />
</div>
Expand All @@ -19,7 +19,7 @@ export default {
},
chromatic: { disableSnapshot: true },
},
};
} as Meta<typeof RadioCard>;

type Story = StoryObj<typeof RadioCard>;

Expand Down
8 changes: 4 additions & 4 deletions packages/chip/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@
"classix": "2.2.0"
},
"peerDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"devDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "19.0.0",
"react-dom": "19.0.0"
}
}
8 changes: 4 additions & 4 deletions packages/clipboard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@
"classix": "2.2.0"
},
"peerDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"devDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "19.0.0",
"react-dom": "19.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/clipboard/src/CopyToClipboard.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { TooltipProps } from '@launchpad-ui/tooltip';
import type { ComponentPropsWithoutRef, KeyboardEventHandler } from 'react';
import type { ComponentPropsWithoutRef, JSX, KeyboardEventHandler } from 'react';

import { Icon } from '@launchpad-ui/icons';
import { Tooltip } from '@launchpad-ui/tooltip';
Expand Down
6 changes: 3 additions & 3 deletions packages/clipboard/stories/CopyToClipboard.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { StoryFn, StoryObj } from '@storybook/react';
import type { Meta, StoryObj } from '@storybook/react';
import type { CopyToClipboardHandleRef } from '../src/CopyToClipboard';

import { userEvent, within } from '@storybook/test';
Expand Down Expand Up @@ -29,7 +29,7 @@ export default {
},
},
decorators: [
(Story: StoryFn) => (
(Story) => (
<div
style={{
height: '100vh',
Expand All @@ -42,7 +42,7 @@ export default {
</div>
),
],
};
} as Meta<typeof CopyToClipboard>;

type Story = StoryObj<typeof CopyToClipboard>;

Expand Down
8 changes: 4 additions & 4 deletions packages/collapsible/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@
"classix": "2.2.0"
},
"peerDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"devDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "19.0.0",
"react-dom": "19.0.0"
}
}
8 changes: 4 additions & 4 deletions packages/columns/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@
"classix": "2.2.0"
},
"peerDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"devDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "19.0.0",
"react-dom": "19.0.0"
}
}
8 changes: 4 additions & 4 deletions packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@
"react-router-dom": "6.16.0"
},
"peerDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1"
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"devDependencies": {
"react": "18.3.1",
"react-dom": "18.3.1",
"react": "19.0.0",
"react-dom": "19.0.0",
"react-stately": "3.34.0"
}
}
3 changes: 2 additions & 1 deletion packages/components/src/Toast.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ interface ToastValue extends IconVariants, ToastContent {}
interface SnackbarContent {
title?: ReactNode;
description: ReactNode;
action?: ReactElement;
// biome-ignore lint/suspicious/noExplicitAny: <explanation>
action?: ReactElement<any>;
}

interface SnackbarValue extends IconVariants, SnackbarContent {}
Expand Down
4 changes: 2 additions & 2 deletions packages/components/stories/Button.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Meta, ReactRenderer, StoryFn, StoryObj } from '@storybook/react';
import type { Meta, ReactRenderer, StoryObj } from '@storybook/react';
import type { PlayFunction } from '@storybook/types';

import { Icon } from '@launchpad-ui/icons';
Expand All @@ -17,7 +17,7 @@ const meta: Meta<typeof Button> = {
},
},
decorators: [
(Story: StoryFn) => (
(Story) => (
<div
style={{ display: 'flex', flexDirection: 'column', alignItems: 'flex-start', gap: '1rem' }}
>
Expand Down
4 changes: 2 additions & 2 deletions packages/components/stories/Checkbox.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Meta, StoryFn, StoryObj } from '@storybook/react';
import type { Meta, StoryObj } from '@storybook/react';

import { vars } from '@launchpad-ui/vars';
import { userEvent, within } from '@storybook/test';
Expand All @@ -15,7 +15,7 @@ const meta: Meta<typeof Checkbox> = {
chromatic: { pauseAnimationAtEnd: true },
},
decorators: [
(Story: StoryFn) => (
(Story) => (
<div style={{ width: vars.size[240] }}>
<Story />
</div>
Expand Down
4 changes: 2 additions & 2 deletions packages/components/stories/ComboBox.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Meta, StoryFn, StoryObj } from '@storybook/react';
import type { Meta, StoryObj } from '@storybook/react';

import { Icon } from '@launchpad-ui/icons';
import { vars } from '@launchpad-ui/vars';
Expand Down Expand Up @@ -28,7 +28,7 @@ const meta: Meta<typeof ComboBox> = {
},
},
decorators: [
(Story: StoryFn) => (
(Story) => (
<div style={{ width: vars.size[240], height: vars.size[240] }}>
<Story />
</div>
Expand Down
4 changes: 2 additions & 2 deletions packages/components/stories/DateField.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Meta, StoryFn, StoryObj } from '@storybook/react';
import type { Meta, StoryObj } from '@storybook/react';

import { vars } from '@launchpad-ui/vars';
import { userEvent } from '@storybook/test';
Expand All @@ -16,7 +16,7 @@ const meta: Meta<typeof DateField> = {
},
},
decorators: [
(Story: StoryFn) => (
(Story) => (
<div style={{ width: vars.size[240] }}>
<Story />
</div>
Expand Down
4 changes: 2 additions & 2 deletions packages/components/stories/DatePicker.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Meta, StoryFn, StoryObj } from '@storybook/react';
import type { Meta, StoryObj } from '@storybook/react';

import { parseDate } from '@internationalized/date';
import { vars } from '@launchpad-ui/vars';
Expand Down Expand Up @@ -32,7 +32,7 @@ const meta: Meta<typeof DatePicker> = {
},
},
decorators: [
(Story: StoryFn) => (
(Story) => (
<div style={{ width: vars.size[320], height: vars.size[480] }}>
<div style={{ width: vars.size[240] }}>
<Story />
Expand Down
Loading
Loading