Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

add support for i18n for EN and FR #105

Closed
wants to merge 7 commits into from
Closed

add support for i18n for EN and FR #105

wants to merge 7 commits into from

Conversation

Netoun
Copy link

@Netoun Netoun commented Oct 20, 2019

This was not required but I added i18n support to allow the management of several languages (en, fr) and add buefy dropdown in navbar to change.

packages : vue-i18n (^8.15.0)

jack-chapman and others added 7 commits October 7, 2019 21:11
@jack-chapman @lauthieb
Upgrade project to use latest version of electron-vue (#93)
8b53008 
* Update to use newest version of electron-vue

* Fix issue with templates not compiling - vue-loader

* Revert Vue version

* Change travis node version to 8.x.x
@lauthieb
fix: use cross-env (#99)
963c28f
@lauthieb
fix: vulnerabilities (#98)
6602d50 
* fix: vulnerabilities

* revert multispinner
@TheFern2 @lauthieb
lint-doc (#101)
1340843
@lauthieb
WIP: Github Enterprise URL Addition (#95)
86b8624 
* ghe-token-test

* fix-conflicts

* input-password

* updated-octokit-rest

* placeholder-update

* fix-request-01

* fix-win-lint

* fix-request-02

* refactor: octokit object creation
@lauthieb
style: margin between cards
13100df
@Netoun
add support for i18n for EN and FR
a035483
@lauthieb
Copy link
Owner

Wow, thanks @Netoun for this great PR.
I will check it as soon as possible. Thanks!

@Netoun
Copy link
Author

Netoun commented Oct 21, 2019

I don't think I translated everything because of lack of time

Moreover, i need a little refacto in value ok key translation. I can take the time this weekend to fix several translations

@lauthieb
Copy link
Owner

As you want @Netoun :)

@lauthieb
Copy link
Owner

lauthieb commented Dec 4, 2019

@Netoun Can you please fix conflicts and update your branch with just your modifications?
Sorry for the inconvenience it was mandatory to force push master after several tries to fix this important bug #110

Here you can download the new version 1.2.3 : https://github.com/lauthieb/code-notes/releases/tag/1.2.3

Thanks a lot in advance for this.

@lauthieb
Copy link
Owner

lauthieb commented Jan 8, 2020

Hi @Netoun, happy new year 🎉
What about the conflict resolution and this issue?
Do you want to continue this Pull Request?
Thanks a in advance. Have a great day :)

@lauthieb lauthieb closed this Mar 3, 2020
@lauthieb
Copy link
Owner

lauthieb commented Mar 3, 2020

Closed for the moment since there is no activity.
Feel free to reopen :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Netoun @lauthieb @jack-chapman @TheFern2