Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Fixes#80 - Source Field added #111

Closed
wants to merge 3 commits into from
Closed

Fixes#80 - Source Field added #111

wants to merge 3 commits into from

Conversation

kartik-budhiraja
Copy link
Contributor

Fixes #80, extra field added for adding a source to the notes.
The source shows up as an icon that takes to the link on click.

lauthieb
lauthieb suggested changes Nov 25, 2019
View reviewed changes
Copy link
Owner

@lauthieb lauthieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @kartik-budhiraja !
Just few comments/suggestions ;)

src/renderer/components/modals/create-note-modal/CreateNoteModal.vue Outdated Show resolved Hide resolved
src/renderer/components/modals/create-note-modal/CreateNoteModal.html Show resolved Hide resolved
@lauthieb
Copy link
Owner

lauthieb commented Nov 25, 2019 •
edited
Loading

@kartik-budhiraja where is the icon?
I don't see it.
image

@lauthieb
Copy link
Owner

lauthieb commented Dec 4, 2019

@kartik-budhiraja Can you please fix conflicts and update your branch with just your modifications?
Sorry for the inconvenience it was mandatory to force push master after several tries to fix this important bug #110

Here you can download the new version 1.2.3 : https://github.com/lauthieb/code-notes/releases/tag/1.2.3

Thanks a lot in advance for this.

@kartik-budhiraja kartik-budhiraja force-pushed the enhancement/source-field branch from 0d3d91f to fa03d8f Compare December 8, 2019 20:46
@kartik-budhiraja
Copy link
Contributor Author

@lauthieb Fixed the branch!!

@kartik-budhiraja
Copy link
Contributor Author

Screen Shot 2019-12-08 at 3 48 39 PM

Screenshot with the source icon on the top

@lauthieb
Copy link
Owner

lauthieb commented Dec 9, 2019

@kartik-budhiraja thanks !
on the top right corner?

@kartik-budhiraja
Copy link
Contributor Author

@lauthieb yes, right next to the edit icon.

@lauthieb
Copy link
Owner

lauthieb commented Mar 3, 2020

Hi :)
Can you please apply my suggestions?

@kartik-budhiraja kartik-budhiraja force-pushed the enhancement/source-field branch from fc1f061 to 65b797b Compare March 3, 2020 04:17
@kartik-budhiraja
Copy link
Contributor Author

Done :)

@lauthieb
Copy link
Owner

Hi @kartik-budhiraja,
I've just marked your Pull Request as closed because it has not had recent activity.
It will be closed if no further activity occurs.
Feel free to reopen it if you have time to contribute and fix conflicts... I haven't got any time to help you on this sorry...
Thanks again for your contributions.

@lauthieb lauthieb closed this Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lauthieb lauthieb lauthieb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request - extra fields
2 participants
@kartik-budhiraja @lauthieb