Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Fixes #91: Frequently used file types #112

Merged

Conversation

kartik-budhiraja
Copy link
Contributor

@kartik-budhiraja kartik-budhiraja commented Nov 25, 2019

Fixes #91

  • Added a searchable dropdown for language type
  • The language list is sorted by use frequency
  • Top 3 used languages show up as buttons right next to the dropdown

Screen Shot 2019-11-24 at 11 47 43 PM

@lauthieb
Copy link
Owner

WOW! Thanks a lot @kartik-budhiraja for this wonderful Pull Request! For me it's OK ❤️

@lauthieb
Copy link
Owner

What do you think @benhalpern? It's a pretty cool answer about your issue #91

@lauthieb
Copy link
Owner

@kodaman2 @jack-chapman @bainternet @guastallaigor @stephengroat feel free to add your comments/suggestions/review before I merge this :)

@TheFern2
Copy link
Contributor

TheFern2 commented Nov 26, 2019 via email

@kartik-budhiraja
Copy link
Contributor Author

@lauthieb @kodaman2 Let me know if I can help anyways to land this code. :)

@TheFern2
Copy link
Contributor

There's an ongoing issue in the latest release (master branch) that imo needs to be addressed before any more PRs get merged. #110 if you are interested in reading more about it, basically at some point during the year a commit broke the app. It looks like just the production, as I couldn't duplicate with dev so something tells me is the minified code perhaps but I haven't been able to fix even after reverting the version on some packages.

@lauthieb
Copy link
Owner

lauthieb commented Dec 4, 2019

@kartik-budhiraja Can you please fix conflicts and update your branch with just your modifications?
Sorry for the inconvenience it was mandatory to force push master after several tries to fix this important bug #110

Here you can download the new version 1.2.3 : https://github.com/lauthieb/code-notes/releases/tag/1.2.3

Thanks a lot in advance for this.

@kartik-budhiraja kartik-budhiraja force-pushed the feature/frequently-used-file-types branch from 580cbe0 to 73047df Compare December 8, 2019 20:06
@kartik-budhiraja kartik-budhiraja force-pushed the feature/frequently-used-file-types branch from 73047df to 08a8652 Compare December 8, 2019 20:24
@kartik-budhiraja
Copy link
Contributor Author

@lauthieb I fixed the branch, so it should be good to go from my side!

@lauthieb lauthieb merged commit 8a818a5 into lauthieb:master Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: "Frequently used file types"
3 participants