-
Notifications
You must be signed in to change notification settings - Fork 145
Fixes #91: Frequently used file types #112
Fixes #91: Frequently used file types #112
Conversation
WOW! Thanks a lot @kartik-budhiraja for this wonderful Pull Request! For me it's OK ❤️ |
What do you think @benhalpern? It's a pretty cool answer about your issue #91 |
@kodaman2 @jack-chapman @bainternet @guastallaigor @stephengroat feel free to add your comments/suggestions/review before I merge this :) |
I don't think anything should be merged until master is fixed.
…On Mon, Nov 25, 2019, 4:28 PM Laurent Thiebault ***@***.***> wrote:
@kodaman2 <https://github.com/kodaman2> @jack-chapman
<https://github.com/jack-chapman> @bainternet
<https://github.com/bainternet> @guastallaigor
<https://github.com/guastallaigor> @stephengroat
<https://github.com/stephengroat> feel free to add your
comments/suggestions/review before I merge this :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#112?email_source=notifications&email_token=ACOKIUQQMTFS4QJVCGSM4WTQVRGSBA5CNFSM4JRDK7EKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEAVWQ#issuecomment-558369498>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOKIURGB5Y6YM3CVFWVTQLQVRGSBANCNFSM4JRDK7EA>
.
|
@lauthieb @kodaman2 Let me know if I can help anyways to land this code. :) |
There's an ongoing issue in the latest release (master branch) that imo needs to be addressed before any more PRs get merged. #110 if you are interested in reading more about it, basically at some point during the year a commit broke the app. It looks like just the production, as I couldn't duplicate with dev so something tells me is the minified code perhaps but I haven't been able to fix even after reverting the version on some packages. |
@kartik-budhiraja Can you please fix conflicts and update your branch with just your modifications? Here you can download the new version 1.2.3 : https://github.com/lauthieb/code-notes/releases/tag/1.2.3 Thanks a lot in advance for this. |
580cbe0
to
73047df
Compare
73047df
to
08a8652
Compare
@lauthieb I fixed the branch, so it should be good to go from my side! |
Fixes #91