Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

move node_js version to nvmrc #113

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Conversation

stephengroat
Copy link
Contributor

removes node js travis dependency
improves compatability with node version managers

@lauthieb
Copy link
Owner

Thanks @stephengroat for this. We are investigating this bug #110 so nothing can be merged before its correction but after I will merge your proposition ;)

@lauthieb
Copy link
Owner

lauthieb commented Dec 4, 2019

@stephengroat Can you please fix conflicts and update your branch with just your modifications?
Sorry for the inconvenience it was mandatory to force push master after several tries to fix this important bug #110

Here you can download the new version 1.2.3 : https://github.com/lauthieb/code-notes/releases/tag/1.2.3

Thanks a lot in advance for this.

@lauthieb lauthieb self-requested a review December 4, 2019 00:04
@stephengroat stephengroat force-pushed the nvmrc branch 2 times, most recently from 6192539 to 5b61dc6 Compare December 9, 2019 05:32
@stephengroat
Copy link
Contributor Author

@lauthieb fixed

@lauthieb
Copy link
Owner

lauthieb commented Dec 9, 2019

Thanks @stephengroat

@lauthieb
Copy link
Owner

lauthieb commented Dec 9, 2019

@stephengroat sorry but the CI is broken with your suggestion.

@stephengroat
Copy link
Contributor Author

@lauthieb could you try a rerun on travis?

all this PR does is move the nvm install step from a hard-coded value to a value pulled from the .nvmrc file (compare failure here https://travis-ci.org/lauthieb/code-notes/jobs/622698139#L87 and success on master https://travis-ci.org/lauthieb/code-notes/jobs/622661291#L73)

since that's the only difference, i don't think this should have any effect

@lauthieb
Copy link
Owner

lauthieb commented Jan 8, 2020

Okay for me & Travis CI!
Thanks @stephengroat :)

@lauthieb lauthieb merged commit 5ce3e7c into lauthieb:master Jan 8, 2020
@stephengroat stephengroat deleted the nvmrc branch January 8, 2020 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants