feat: Tabs for Multiple Files

[Andrei0872]

Closes #72

Whether updating or creating a note, instead of showing files one after the other, display them horizontally as tabs.

Please let me know if there is anything I need to change.

[lauthieb]

Wow @Andrei0872, thanks a lot for your PR!
I’ll review the code pretty soon. Thanks for this contribution!

[lauthieb]

Hello @Andrei0872,
Before going to the code, I have tested your feature in development mode.
Here is my remarks:

• When I create a note with only 1 file, it would be nice if we can save it without click on "Add a file" button.
• The tabs on top are confusing, maybe this tab bar should go at the bottom of a note...
• You have a UI bug when we click on a tab, check this GIF:
  

Thanks a lot for your contribution. If you can fix my remarks, I will review the code deeply and sure this PR could be merged ;)

[Andrei0872]

Thank you for the feedback, @lauthieb!
I’ll fix the remarks as soon as possible.

[Andrei0872]

Hello, @lauthieb ! I just sent my attempt to fix the remarks.
I couldn't reproduce the 3rd one since the tab bar is now on the bottom.

[lauthieb]

Hi @Andrei0872, can you fix these conflicts?
Why can't you reproduce my 3rd remark?

[Andrei0872]

Hi, @lauthieb!
I couldn’t reproduce the error since in the gif the tabs were placed at the top of the card and now they are at the bottom.

I’m not sure I followed all the rules there, but I’ll have a look at it tomorrow:)

[lauthieb]

Hi @Andrei0872, can you fix conflicts by removing the yarn.lock please?

[lauthieb]

I think I will merge pretty soon this #93 Pull Request to correct the actual bug (#92), then I will go through your Pull Request to merge this.
Sorry again for the delay... Ah.. Open Source :) (#bestEffort)

[Andrei0872]

Hi @lauthieb, I fixed the conflicts and hopefully everything should be working fine!

[lauthieb]

Thanks @Andrei0872 !
Did you try to reinstall your node modules?
It seems your development doesn't work when npm run dev:

[Andrei0872]

Hi @lauthieb , just pushed the fix!

[lauthieb]

I always have this UI bug when I create/update a file (when I click on the button to display a file) even if tabs are in bottom.

[Andrei0872]

Hmm.. that's odd(regarding the first issue). I have rebased my branch onto master(this master) and I can't explain why there is no margin between notes 🤔.

Also, I couldn't reproduce the bug..

[lauthieb]

@Andrei0872 Can you please fix conflicts and update your branch with just your modifications?
Sorry for the inconvenience it was mandatory to force push master after several tries to fix this important bug #110

Here you can download the new version 1.2.3 : https://github.com/lauthieb/code-notes/releases/tag/1.2.3

Thanks a lot in advance for this.

[lauthieb]

Hi @Andrei0872, happy new year 🎉
What about the conflict resolution? Do you want to continue this Pull Request?
Thanks a in advance. Have a great day :)

[Andrei0872]

Hi @lauthieb, Happy New Year!
Sorry, I didn't notice the previous comment. Sure, I'll have look. Hopefully, I'll get it done by the evening.

Thank you!

[lauthieb]

Thanks @Andrei0872, take time if needed, no problem.
And feel free if you have any question.

[Andrei0872]

Hi @lauthieb , I fixed the conflicts, but when I run npm run dev, I get this error:

const { Template, util: { createHash } } = _webpack2.default;
                          ^
TypeError: Cannot destructure property `createHash` of 'undefined' or 'null'.

It might happen due to webpack's current version?

I took a look at this issue.

[lauthieb]

Hi @Andrei0872, are you sure? I see always

on your PR

[Andrei0872]

Hmm. ~9k are from yarn-error.log which I guess it should be deleted. The other ~6.4k are from package-lock.json.
What should I do?

[lauthieb]

Hi @Andrei0872,
I've just marked your Pull Request as closed because it has not had recent activity.
It will be closed if no further activity occurs.
Feel free to reopen it if you have time to contribute and fix conflicts... I haven't got any time to help you on this sorry...
Thanks again for your contributions.