-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for issues #3286, #3663, Partner Page SVG Transitions, and Catalog Page Transitions #4296
Conversation
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
Signed-off-by: Randy Lau <[email protected]>
🚀 Preview for commit b650fe4 at: https://6470575b8de3c956ac164239--layer5.netlify.app |
@randychilau Let's discuss this on websites call, I'll add this as an agenda item in meeting minutes. |
@randychilau Is this PR ready from your side? |
Hi @Shivam-AfA, Thanks for the message and checking the status of this PR. I forgot to mention in the Notes that the package-lock.json file has been updated and should be included with the merge. There is a version change of a Layer5 Lab package. The new version removes console.logs that were used for testing in the build process. Thanks again, |
Signed-off-by: Randy Lau <[email protected]>
Note: Also added a commit to fix an eslint warning on spacing that I missed in this file on a recently merged PR. Thanks! |
🚀 Preview for commit 8a69794 at: https://647b738a1de38023e96b0e18--layer5.netlify.app |
Great work @randychilau 👍🏽 |
Signed-off-by: Randy Lau <[email protected]>
fyi: this PR was discussed on the Websites Weekly Call May 29th, 2023 (timestamp: 14.57). happy to answer any other questions on this. Cheers, |
Signed-off-by: Randy Lau <[email protected]>
🚀 Preview for commit 481e59c at: https://647e5dcc1991352a6108f1da--layer5.netlify.app |
Signed-off-by: Randy Lau <[email protected]>
🚀 Preview for commit 1cc4fe2 at: https://64875e7a9f501a07ff06b177--layer5.netlify.app |
This is a great PR @randychilau. Your documentation and explanation skills are a delight. Thanks for these contributions. 🚀 |
@@ -30,23 +30,50 @@ import Button from "../../../../reusecore/Button"; | |||
</div> | |||
|
|||
<p> | |||
One way to further enhance your use of Terraform is by integrating it with Meshery. Meshery is a cloud-native management platform that provides a unified interface for managing and monitoring your infrastructure resources, including those managed by Terraform. By integrating Terraform with Meshery, you can leverage the power and flexibility of both tools to streamline your infrastructure management process. | |||
One way to further enhance your use of Terraform is by integrating it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@randychilau Just a question, why are we modifying this file by puttig line breaks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Shivam-AfA,
Thanks for your message and working on this PR.
This file was mainly edited to update the <ResourceWrapper>
tag to <ResourcesWrapper>
to match the import statement:
import { ResourcesWrapper } from "../../Resources.style.js";
and clear a MDX warning that was appearing during builds:
warn Component ResourceWrapper was not imported, exported, or provided by MDXProvider as global scope
Not sure if I also made edits to the spacing as part of general page cleanup/tidying.
Feel free to let me know if you would like me to remove the line break edits.
Thanks,
Randy
I agree with @Shivam-AfA. |
Signed-off-by: Shivam Sood <[email protected]>
🚀 Preview for commit 481f033 at: https://648e97bfcc1ae5769516a1d5--layer5.netlify.app |
@randychilau I removed the line breaks in the blog. Merging this PR... |
Hi @Shivam-AfA, Thanks for taking the time to review and merge the PR! Cheers, |
Description
This PR fixes:
#3286
#3663
Partner Page SVG transition Issues
Catalog Page Dark Mode transition issues
Clearing dev warnings
PR 3286 Smoothly displaying the answers in the FAQ on page /careers/programs
Fix is credited to this post.
before:
accordian_snap.webm
with fix:
accordian_fix.1.webm
PR 3663 Dark-mode: Unable to see text highlight on selection of text
Fix is credited to this post
before:
safari_selection.webm
with fix:
text_selected_safari.webm
Partner Page SVG Issues:
before:
partner_issues.webm
after:
partner_fixed.webm
Catalog Page transition issues:
before:
catalog_before.webm
after:
catalog_after.webm
Cleared the following dev warnings:
warn Component ResourceWrapper was not imported, exported, or provided by MDXProvider as global scope
warn Component ChapterStyle was not imported, exported, or provided by MDXProvider as global scope
Notes for Reviewers
Please feel free to let me know if I have to break this into separate PRs or remove a portion of this PR for whatever reasons.
Regarding the issues 3268, 3663, I was looking to fix older issues that have gone stale or were
and either
or
I have added comments to other similar older issues that perhaps needed some additional clarification to help reach
closed
status:Also note, the package-lock.json has been updated for a more recent version of a custom package from the Layer5 Labs account. The newer version removes console.logs that were used for testing in the build process.
Signed commits