OP has implemented RO code. using this one in Loket instead #472
+73
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think that many other things need to be updated, for example some BesluitDocumentType seem to be decidable (<http://lblod.data.gift/vocabularies/besluit/decidableBy>) by the old RO classification so those links would need to be updated in the DB.
I'm also not sure about the consequence of this change on submitted data, if it's then published and consumed elsewhere it could cause some issues but I don't have enough knowledge on Loket to be certain about it, @cecemel will probably have more insights
| # ?s a ere:RepresentatiefOrgaan | ||
| # }=> { | ||
| # ?s | ||
| # a besluit:Bestuurseenheid; |
There was a problem hiding this comment.
I think that we still need to add the besluit:Bestuurseenheid type because ACMIDM needs it for the log in ? Not 100% sure, but worth checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DL-5462