Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versionedNotulen never fetching filecontent #213

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abeforgit
Copy link
Member

@abeforgit abeforgit commented Nov 14, 2024

Overview

connected issues and PRs:

Most work in lblod/notulen-prepublish-service#118
Jira: GN-5226

Setup

checkout and mount lblod/notulen-prepublish-service#118

  prepublish:
    restart: "no"
    ports:
      # for chrome's node debugger if you want
      - "4391:9229" 
    environment:
      NODE_ENV: development
    volumes:
      - ../notulen-prepublish-service/:/app

How to test/reproduce

I initially thought this bug means that the second signature would just never work, but that seems to not be the case. Which means we still don't know how linkebeek ended up in the state where they have multiple documents for one signed resource.

However, the bug is still problematic in that it generates a new filecontent for every signed resource, rather than linking the same file to both signed resources. This is still ugly data, and it's only legally ok if both files have exactly identical content. AFAICT they do, but it's risky anyway.

Challenges/uncertainties

Checks PR readiness

  • changelog
  • no new deprecations

@abeforgit abeforgit changed the title Add Error type to auth config Fix second signature failing Nov 14, 2024
@abeforgit abeforgit marked this pull request as draft November 14, 2024 18:02
@abeforgit abeforgit changed the title Fix second signature failing Fix versionedNotulen never fetching filecontent Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant