Fix versionedNotulen never fetching filecontent #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
connected issues and PRs:
Most work in lblod/notulen-prepublish-service#118
Jira: GN-5226
Setup
checkout and mount lblod/notulen-prepublish-service#118
How to test/reproduce
I initially thought this bug means that the second signature would just never work, but that seems to not be the case. Which means we still don't know how linkebeek ended up in the state where they have multiple documents for one signed resource.
However, the bug is still problematic in that it generates a new filecontent for every signed resource, rather than linking the same file to both signed resources. This is still ugly data, and it's only legally ok if both files have exactly identical content. AFAICT they do, but it's risky anyway.
Challenges/uncertainties
Checks PR readiness