Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IV LMB queries: add support for 'district' bestuurseenheden #745

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elpoelma
Copy link
Contributor

Overview

This PR adds support to the LMB queries for 'district' bestuurseenheden.
Specifically, the 'gemeenteraads' queries are adjusted to also work for 'districten'.

connected issues and PRs:

None

Setup

  • Set-up the backend
  • Ensure the ldes-client service has run

How to test/reproduce

  • Quite difficult as the 'Opstart nieuwe legislatuur' feature is not yet enabled for 'district' bestuurseenheden on LMB
  • Start the frontend
  • Log in as a 'district' (e.g. 'Berchem')
  • Create an IV
  • The sync should run without errors

Challenges/uncertainties

The implementation is a bit hacky, as we just use a simple object to look up the correct 'classificatie-codes' for 'districten'/'gemeentes'.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the enhancement New feature or request label Oct 28, 2024
@elpoelma elpoelma self-assigned this Oct 28, 2024
@elpoelma elpoelma changed the base branch from master to fix/iv-lmb-queries-bestuursorgaan October 28, 2024 11:33
@elpoelma elpoelma force-pushed the fix/iv-lmb-queries-bestuursorgaan branch 3 times, most recently from a3365ca to 138ceab Compare October 28, 2024 12:20
@elpoelma elpoelma force-pushed the feat/iv-lmb-queries-districts branch from 0fc5ddf to 1691244 Compare October 28, 2024 12:27
@elpoelma elpoelma force-pushed the feat/iv-lmb-queries-districts branch from 1691244 to e03c523 Compare October 28, 2024 12:33
Base automatically changed from fix/iv-lmb-queries-bestuursorgaan to master October 30, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant