Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GN-5217: person variable adjustments #769

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

GN-5217: person variable adjustments #769

wants to merge 1 commit into from
+5 −5

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Nov 14, 2024 •
edited
Loading

Overview

PR created to test lblod/ember-rdfa-editor-lblod-plugins#504

connected issues and PRs:

GN-5217
lblod/ember-rdfa-editor-lblod-plugins#504

Setup

None

How to test/reproduce

  • Start the frontend
  • Login as a municipality/OCMW
  • Open/create an agendapoint
  • Ensure you can now insert any electee in the document

Checks PR readiness

  • changelog
  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • npm lint

@elpoelma elpoelma added the enhancement New feature or request label Nov 14, 2024
@elpoelma elpoelma mentioned this pull request Nov 14, 2024
Merged
8 tasks
@elpoelma elpoelma marked this pull request as draft November 14, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lagartoverde lagartoverde Awaiting requested review from lagartoverde

@abeforgit abeforgit Awaiting requested review from abeforgit

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elpoelma