Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: next hard fork #5

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

WIP: next hard fork #5

wants to merge 7 commits into from

Conversation

BrannonKing
Copy link
Member

@BrannonKing BrannonKing commented Aug 12, 2021 •
edited
Loading

This hard fork achieves the following changes:

  • Claims never expire
  • Restrictions on claim names will be enforced as part of block validation (as now they are only enforced in the mempool).
  • Some current delay computation bugs will be bypassed.
  • Claims on the empty name will not be included in the trie hash (and won't be bid-provable).
  • The trie hash function will change to include name, bid, sequence, and ClaimID, enabling full proof on any of those.
  • Proof RPC calls will be added to go with the new hash function.
  • Claim delay calculations will use original height rather than last update height?
  • Possible: Trie hash computations will switch to single SHA256 instead of double SHA256?
  • Possible: full support for timelocked utxos?
  • MinFeePerNameclaimChar will go away.
  • 8k bytes name+data cap should go to 12k?

@BrannonKing BrannonKing force-pushed the WIP-HF-2022 branch 2 times, most recently from 04bdc76 to 78640e5 Compare August 14, 2021 17:21
@coveralls
Copy link

coveralls commented Aug 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1225402214

  • 35 of 304 (11.51%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 30.225%
Changes Missing Coverage Covered Lines Changed/Added Lines %
blockchain/validate.go 0 1 0.0%
claimtrie/merkletrie/merkletrie.go 0 2 0.0%
claimtrie/node/node.go 8 10 80.0%
claimtrie/node/manager.go 1 7 14.29%
claimtrie/node/hashfunc.go 0 47 0.0%
claimtrie/merkletrie/ramtrie.go 0 48 0.0%
rpcclaimtrie.go 0 52 0.0%
blockchain/claimtrie.go 0 53 0.0%
claimtrie/node/hashfork_manager.go 0 58 0.0%
Totals Coverage Status
Change from base Build 1225378357: -0.05%
Covered Lines: 12571
Relevant Lines: 41592
💛 - Coveralls

@BrannonKing BrannonKing added the type: improvement Existing (or partially existing) functionality needs to be changed label Aug 23, 2021
@BrannonKing BrannonKing force-pushed the WIP-HF-2022 branch 2 times, most recently from 0797cca to 0a655bb Compare September 12, 2021 00:15
@roylee17 roylee17 force-pushed the master branch 4 times, most recently from e97a5db to 3f2a2b1 Compare December 15, 2021 16:59
@roylee17 roylee17 force-pushed the master branch 6 times, most recently from aaf8792 to aef4e45 Compare May 24, 2022 09:49
@BrannonKing
new claim hash function includes bid, seq, name
70d1d18 
fixed namespace
@BrannonKing
added proof RPC
e9b2cbb 
post-merge fixes

other part of test
post-merge fix
@BrannonKing
post-rebase fixes
5a99dcf 
post-rebase fixes 2
@lbryio lbryio deleted a comment from coveralls Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BrannonKing BrannonKing

Labels
type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrannonKing @coveralls