Remove V2 from the header #364
Annotations
23 warnings
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-dotnet@v3, codecov/codecov-action@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
src/LeanCode.Contracts/Binary.cs#L30
Provide a method named 'ToByteArray' or 'FromNullable' as an alternate for operator op_Implicit (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2225)
|
src/LeanCode.Contracts/Binary.cs#L8
Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)
|
src/LeanCode.Contracts/Security/AuthorizeWhenHasAnyOfAttribute.cs#L10
Add a public read-only property accessor for positional argument permissions of Attribute AuthorizeWhenHasAnyOfAttribute (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1019)
|
src/LeanCode.Contracts/Security/AuthorizeWhenAttribute.cs#L22
Change 'List<AuthorizeWhenAttribute.AuthorizerDefinition>' in 'AuthorizeWhenAttribute.GetCustomAuthorizers<T>()' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
src/LeanCode.Contracts/Security/AuthorizeWhenAttribute.cs#L25
Change 'List<AuthorizeWhenAttribute.AuthorizerDefinition>' in 'AuthorizeWhenAttribute.GetCustomAuthorizers(Type)' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
src/LeanCode.Contracts/NotificationTagGenerator.cs#L32
'string.IndexOf(char)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'LeanCode.Contracts.NotificationTagGenerator.GetSimpleName(System.Type)' with a call to 'string.IndexOf(char, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
src/LeanCode.Contracts/Security/AuthorizeWhenAttribute.cs#L59
Change 'List<AuthorizeWhenAttribute.AuthorizerDefinition>' in 'AuthorizeWhenAttribute<T>.GetCustomAuthorizers()' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
src/LeanCode.Contracts/CommandResult.cs#L20
In externally visible method 'CommandResult CommandResult.NotValid(ValidationResult validationResult)', validate parameter 'validationResult' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
src/LeanCode.Contracts/NotificationTagGenerator.cs#L46
Prefer comparing 'Length' to 0 rather than using 'Any()', both for clarity and for performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
|
src/LeanCode.Contracts/NotificationEnvelope.cs#L16
In externally visible method 'NotificationEnvelope.NotificationEnvelope(Guid id, ITopic topic, object notification)', validate parameter 'topic' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
src/LeanCode.Contracts/Binary.cs#L30
Provide a method named 'ToByteArray' or 'FromNullable' as an alternate for operator op_Implicit (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2225)
|
src/LeanCode.Contracts/Binary.cs#L8
Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)
|
src/LeanCode.Contracts/Security/AuthorizeWhenHasAnyOfAttribute.cs#L10
Add a public read-only property accessor for positional argument permissions of Attribute AuthorizeWhenHasAnyOfAttribute (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1019)
|
src/LeanCode.Contracts/CommandResult.cs#L20
In externally visible method 'CommandResult CommandResult.NotValid(ValidationResult validationResult)', validate parameter 'validationResult' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
src/LeanCode.Contracts/Security/AuthorizeWhenAttribute.cs#L59
Change 'List<AuthorizeWhenAttribute.AuthorizerDefinition>' in 'AuthorizeWhenAttribute<T>.GetCustomAuthorizers()' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
src/LeanCode.Contracts/Security/AuthorizeWhenAttribute.cs#L22
Change 'List<AuthorizeWhenAttribute.AuthorizerDefinition>' in 'AuthorizeWhenAttribute.GetCustomAuthorizers<T>()' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
src/LeanCode.Contracts/Security/AuthorizeWhenAttribute.cs#L25
Change 'List<AuthorizeWhenAttribute.AuthorizerDefinition>' in 'AuthorizeWhenAttribute.GetCustomAuthorizers(Type)' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
src/LeanCode.Contracts/NotificationEnvelope.cs#L16
In externally visible method 'NotificationEnvelope.NotificationEnvelope(Guid id, ITopic topic, object notification)', validate parameter 'topic' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
src/LeanCode.Contracts/NotificationEnvelope.cs#L17
In externally visible method 'NotificationEnvelope.NotificationEnvelope(Guid id, ITopic topic, object notification)', validate parameter 'notification' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
src/LeanCode.Contracts/NotificationTagGenerator.cs#L32
'string.IndexOf(char)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'LeanCode.Contracts.NotificationTagGenerator.GetSimpleName(System.Type)' with a call to 'string.IndexOf(char, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "test_results_6.0.zip", "test_results_7.0.zip".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
This job succeeded
Loading