Merge pull request #157 from leancodepl/feature/add-records #359
Annotations
21 warnings
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Build:
src/LeanCode.Contracts/Binary.cs#L8
Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)
|
Build:
src/LeanCode.Contracts/Binary.cs#L30
Provide a method named 'ToByteArray' or 'FromNullable' as an alternate for operator op_Implicit (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2225)
|
Build:
src/LeanCode.Contracts/NotificationTagGenerator.cs#L32
'string.IndexOf(char)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'LeanCode.Contracts.NotificationTagGenerator.GetSimpleName(System.Type)' with a call to 'string.IndexOf(char, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
Build:
src/LeanCode.Contracts/NotificationTagGenerator.cs#L46
Prefer comparing 'Length' to 0 rather than using 'Any()', both for clarity and for performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
|
Build:
src/LeanCode.Contracts/Converters/BinaryJsonConverter.cs#L6
Type 'BinaryJsonConverter' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
|
Build:
src/LeanCode.ContractsGenerator/Analyzers/KnownTypeCheck.cs#L5
Change type of field 'ValidKnownTypeValues' from 'System.Collections.Generic.IReadOnlySet<LeanCode.ContractsGenerator.KnownType>' to 'System.Collections.Generic.HashSet<LeanCode.ContractsGenerator.KnownType>' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
Build:
src/LeanCode.ContractsGenerator/Compilation/CompilationFailedException.cs#L28
The behavior of 'StringBuilder.AppendLine(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'CompilationFailedException.GetDiagnosticsMessage(ImmutableArray<Diagnostic>)' with a call to 'StringBuilder.AppendLine(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
Build:
src/LeanCode.ContractsGenerator/Compilation/CompilationFailedException.cs#L28
The behavior of 'Diagnostic.GetMessage([IFormatProvider])' could vary based on the current user's locale settings. Provide a value for the 'IFormatProvider' argument. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
Build:
src/LeanCode.ContractsGenerator/Generation/NotificationTagGenerator.cs#L29
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
|
Build:
src/LeanCode.ContractsGenerator/Generation/NotificationTagGenerator.cs#L33
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
|
Test:
src/LeanCode.Contracts/Binary.cs#L30
Provide a method named 'ToByteArray' or 'FromNullable' as an alternate for operator op_Implicit (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2225)
|
Test:
src/LeanCode.Contracts/Binary.cs#L8
Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)
|
Test:
src/LeanCode.Contracts/NotificationTagGenerator.cs#L32
'string.IndexOf(char)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'LeanCode.Contracts.NotificationTagGenerator.GetSimpleName(System.Type)' with a call to 'string.IndexOf(char, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
Test:
src/LeanCode.Contracts/NotificationTagGenerator.cs#L46
Prefer comparing 'Length' to 0 rather than using 'Any()', both for clarity and for performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
|
Test:
src/LeanCode.Contracts/Converters/BinaryJsonConverter.cs#L6
Type 'BinaryJsonConverter' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
|
Test:
src/LeanCode.Contracts/Binary.cs#L30
Provide a method named 'ToByteArray' or 'FromNullable' as an alternate for operator op_Implicit (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2225)
|
Test:
src/LeanCode.Contracts/Binary.cs#L8
Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)
|
Test:
src/LeanCode.Contracts/Security/AuthorizeWhenHasAnyOfAttribute.cs#L10
Add a public read-only property accessor for positional argument permissions of Attribute AuthorizeWhenHasAnyOfAttribute (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1019)
|
Test:
src/LeanCode.Contracts/Security/AuthorizeWhenAttribute.cs#L59
Change 'List<AuthorizeWhenAttribute.AuthorizerDefinition>' in 'AuthorizeWhenAttribute<T>.GetCustomAuthorizers()' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
Test:
src/LeanCode.Contracts/Security/AuthorizeWhenAttribute.cs#L22
Change 'List<AuthorizeWhenAttribute.AuthorizerDefinition>' in 'AuthorizeWhenAttribute.GetCustomAuthorizers<T>()' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
The logs for this run have expired and are no longer available.
Loading