[COR-123] Support records #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saancreed
reviewed
Dec 11, 2023
src/LeanCode.ContractsGenerator.Tests/ExampleBased/Properties.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I would also add a test for a record being command/query/opertation.
Plus, this needs fixing.
Saancreed
reviewed
Dec 11, 2023
|
Also, forgot about it - changelog change is needed :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 81.76% 81.97% +0.20%
==========================================
Files 37 37
Lines 1300 1315 +15
Branches 127 130 +3
==========================================
+ Hits 1063 1078 +15
Misses 190 190
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| public record DTO1(int Property); | ||
| public record DTO2(string Property); | ||
|
|
||
| public class Command : ICommand |
There was a problem hiding this comment.
I meant that we should check if this will work:
public record Command(DTO1 DTO1) : ICommand;
et al. :)
There was a problem hiding this comment.
Huh, didn't think about this one, but it looks like it works as well
jakubfijalkowski
approved these changes
Dec 12, 2023
Saancreed
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumed, that we do not want clients to have distinction between record type DTOs and class type DTOs.