Merge pull request #54 from leancodepl/tiltfiles-refactors #180
Annotations
10 warnings
Build:
publisher/test/LeanCode.Pipe.ClientIntegrationTestsApp.Contracts/AuthConfig.cs#L5
Do not nest type Roles. Alternatively, change its accessibility so that it is not externally visible. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1034)
|
Build:
publisher/test/LeanCode.Pipe.ClientIntegrationTestsApp.Contracts/AuthConfig.cs#L10
Do not nest type KnownClaims. Alternatively, change its accessibility so that it is not externally visible. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1034)
|
Build:
publisher/src/LeanCode.Pipe/Funnel/SubscriptionPipelineResult.cs#L5
Change 'List<string>' in 'SubscriptionPipelineResult.GroupKeys' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
Build:
publisher/src/LeanCode.Pipe/BasicTopicKeys.cs#L16
Rename virtual/interface member BasicTopicKeys<TT>.Get(TT) so that it no longer conflicts with the reserved language keyword 'Get'. Using a reserved keyword as the name of a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
|
Build:
publisher/src/LeanCode.Pipe/BasicTopicKeys.cs#L30
Rename virtual/interface member BasicTopicKeys<TT, TN1>.Get(TT) so that it no longer conflicts with the reserved language keyword 'Get'. Using a reserved keyword as the name of a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
|
Build:
publisher/src/LeanCode.Pipe/Funnel/SubscriptionPipelineResult.cs#L5
Change 'List<string>' in 'SubscriptionPipelineResult.SubscriptionPipelineResult(SubscriptionStatus, List<string>)' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
Build:
publisher/src/LeanCode.Pipe/Funnel/FunnelledService/TopicExistenceChecker.cs#L20
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
Build:
publisher/src/LeanCode.Pipe/TopicExtractor.cs#L30
In externally visible method 'ITopic? DefaultTopicExtractor.Extract(SubscriptionEnvelope envelope)', validate parameter 'envelope' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
Build:
publisher/src/LeanCode.Pipe/Funnel/FunnelledService/TopicExistenceChecker.cs#L16
In externally visible method 'Task TopicExistenceChecker.Consume(ConsumeContext<CheckIfTopicIsRecognized> context)', validate parameter 'context' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
Build:
publisher/src/LeanCode.Pipe/Funnel/FunnelledService/FunnelledSubscriber.cs#L22
Consider calling ConfigureAwait on the awaited task (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2007)
|
The logs for this run have expired and are no longer available.
Loading