Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funnel integration tests & funnelled notifications serialization fix #41

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

Dragemil
Copy link
Collaborator

Now the Funnel is truly compatible with the non Funnelled LeanPipe.

@github-actions
Copy link

Test Results

  4 files    4 suites   49s ⏱️
55 tests 55 ✔️ 0 💤 0
69 runs  69 ✔️ 0 💤 0

Results for commit 76f5bea.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #41 (76f5bea) into main (0b59b28) will increase coverage by 8.88%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   77.67%   86.56%   +8.88%     
==========================================
  Files          30       30              
  Lines         681      685       +4     
  Branches       55       55              
==========================================
+ Hits          529      593      +64     
+ Misses        131       70      -61     
- Partials       21       22       +1     
Files Coverage Δ
...nel/FunnelledService/FunnelledLeanPipePublisher.cs 100.00% <100.00%> (+100.00%) ⬆️
...el/FunnelledService/ServiceCollectionExtensions.cs 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dragemil Dragemil merged commit e6721c5 into main Oct 26, 2023
5 checks passed
@Dragemil Dragemil deleted the publisher/funnel-integration-tests branch October 26, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants