Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Dtype bits and arithmetic logic #39

Closed
wants to merge 2 commits into from

Conversation

seanmcl
Copy link
Collaborator

@seanmcl seanmcl commented Feb 25, 2025

Dtype will soon replace Element as the method of doing array indexing and arithmetic. This PR adds some methods to that end.

Copy link
Collaborator

@govereau govereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor questions.

@seanmcl
Copy link
Collaborator Author

seanmcl commented Feb 26, 2025

Sorry, merged this by accident when trying to merge the npy file change that was stacked on top of this. Not sure exactly how I messed up, but will create a new PR with the changes proposed.

@seanmcl seanmcl closed this Feb 26, 2025
seanmcl added a commit that referenced this pull request Feb 26, 2025
As I was testing testing, I forgot to fix my test.
Also responded to an unresolved comment from
#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants