chore: Make all arrays little-endian #48
Merged
+143
−330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Endian-ness is a nice feature in NumPy; it's clear what the data should represent, it handles operations on arrays with different orderings, etc. But it's largely just an optimization. In our code, which is slow to begin with, we do not need this optimization. We remove considerable complexity by forcing all arrays in TensorLib to be little-endian. One outcome of this is that we will save all .npy files as littleendian and rely on the Python programmer to convert if necessary.
govereau
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endian-ness is a nice feature in NumPy; it's clear what the data should represent, it handles operations on arrays with different orderings, etc. But it's largely just an optimization. In our code, which is slow to begin with, we do not need this optimization. We remove considerable complexity by forcing all arrays in TensorLib to be little-endian.
One outcome of this is that we will save all .npy files as littleendian and rely on the Python programmer to convert if necessary.