Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix bug in Slice.size, prove size d <= d #49

Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix: Fix bug in Slice.size, prove size d <= d #49

merged 1 commit into from
Mar 7, 2025

Conversation

seanmcl
Copy link
Collaborator

@seanmcl seanmcl commented Mar 7, 2025

Bug was found while working on the proof.

seanmcl
seanmcl commented Mar 7, 2025
View reviewed changes
Copy link
Collaborator Author

@seanmcl seanmcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the dependent match here because it was very hard to prove things about. John Tristan said they never use dependent matches in compcert for this reason.

govereau
govereau approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@govereau govereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Hooray for theorem proving.

@seanmcl seanmcl merged commit 81f5c85 into main Mar 7, 2025
1 check passed
@seanmcl seanmcl deleted the sm/size-proof branch March 7, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@govereau govereau govereau approved these changes

@jtristan jtristan Awaiting requested review from jtristan jtristan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanmcl @govereau