Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build workflow to include codecov upload step #238

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

samirsilwal
Copy link
Collaborator

@samirsilwal samirsilwal commented Oct 15, 2024

Changes

@samirsilwal
Copy link
Collaborator Author

@mesaugat Need to add token to secrets with name CODECOV_TOKEN

@mesaugat
Copy link
Member

mesaugat commented Oct 15, 2024

@samirsilwal Thanks. Let me look at that. Can you also update the package.json version to 2.2.0 and commit the change. The workflow only publishes a new package version when package.json version is a new one.

@samirsilwal
Copy link
Collaborator Author

@samirsilwal Thanks. Let me look at that. Can you also update the package.json version to 2.2.0 and commit the change. The workflow only publishes a new package version when package.json version is a new one.

Sure will make the changes

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.34%. Comparing base (f705959) to head (fa539a6).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   35.26%   35.34%   +0.07%     
==========================================
  Files          33       33              
  Lines         862      863       +1     
  Branches      116      115       -1     
==========================================
+ Hits          304      305       +1     
  Misses        549      549              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mesaugat mesaugat self-requested a review October 16, 2024 08:08
Copy link
Member

@mesaugat mesaugat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samirsilwal Codecov now works. I added the token and integrated the Codecov app in the repository.

Also, changed the package version to 2.2.0 to publish a new package version.

@mesaugat mesaugat merged commit a741849 into master Oct 16, 2024
7 checks passed
@mesaugat mesaugat deleted the fix/update-codecov-use branch October 16, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants