-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oops, disregard this PR, never used or released #4944
Closed
benjaoming
wants to merge
49
commits into
learningequality:develop
from
benjaoming:prereleases/0.16b1
Closed
oops, disregard this PR, never used or released #4944
benjaoming
wants to merge
49
commits into
learningequality:develop
from
benjaoming:prereleases/0.16b1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't even bother caching a list of facilities on the central server.
…facilities Don't load facilities into session object.
Catch pops from an empty list.
So it doesn't see random stuff that lies around in a dev's machine.
…into new_message
…s you are set_sidebar_visibility).
…-server Change message for the user while they wait for server response
Removed overlapping text of content recommendation explore
shows a message when the search returns no content
…ent_rec Add catches for missing data or None returns in content data.
…video related things.
…and in update topic tree.
The given attribute "template" is not returned by the exercise endpoint. A pure, simple error.
It does not *directly* test the issue resolved, but we don't have a good way to unit test js. But it's a good idea to get test coverage for the views anyway.
Properly create content item, add extra fields to expected output
…messages Add more ignore patterns when making messages
…d on API endpoints.
Adds comments and documentation for api views.
Miscellaneous fixes
It choked on valid commands like: `kalite manage retrievecontentpack local es-ES foo.zip` Because of the dash in the middle of a positional argument. So only match if there is preceding whitespace. Also remove redundant non-capturing group -- negative lookaheads don't capture anyway.
…_fixes Video download fixes
pt-BR works fine without it. In fact, having this mapping now prevents the content db from being annotated properly.
Remove that custom pt-BR -> pt mapping.
…_topics Propagates topic selection to tabular coach report.
…se-bug Allow positional arguments with dashes inside
…nt_content_rec Fixes display issues for icomoon icons used in content recommendation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING! Merging this, merges and closes all PRs contained in this PR, and they may have a separate review process and amendments following. So don't merge this PR!! :)
Takes over 0.16a4 #4915
New release, manually brewing the distributions:
Known issues
Included PRs
Installer links