Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually update the target filename for the windows installer build. #222

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Actually update the target filename for the windows installer build. #222

merged 1 commit into from
Apr 5, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Apr 5, 2024 •
edited
Loading

To verify this change, look at the built asset.

Download the built asset zip file, and confirm that the asset inside is called kolibri-<version>-windows-setup-unsigned.exe

marcellamaki
marcellamaki approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated file names match ✅

@marcellamaki marcellamaki merged commit c3efae6 into main Apr 5, 2024
3 checks passed
@rtibbles rtibbles deleted the fool_me_once_name_on_you branch April 5, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcellamaki marcellamaki marcellamaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @marcellamaki