Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split embed request schema #120

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Split embed request schema #120

merged 3 commits into from
Jan 30, 2024

Conversation

akolson
Copy link
Member

@akolson akolson commented Jan 25, 2024

Overview

This pr splits the embed_request json schema into two schemas;

  1. embed_topics_request
  2. embed_content request

References

Closes #119

@akolson akolson requested review from jamalex and bjester January 25, 2024 20:31
@bjester bjester self-assigned this Jan 30, 2024
bjester
bjester reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bump the version to 0.2.4, like 2d708e2

bjester
bjester approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester bjester merged commit 669d9b3 into learningequality:main Jan 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjester bjester bjester approved these changes

@jamalex jamalex Awaiting requested review from jamalex

Assignees

@bjester bjester

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split the embed_request json schema
2 participants
@akolson @bjester