Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added update-spreadsheet action #149

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

GarvitSinghal47
Copy link
Contributor

Summary

References

Reviewer guidance

@MisRob MisRob requested review from rtibbles and MisRob November 20, 2024 06:49
@MisRob MisRob self-assigned this Nov 20, 2024
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me here! Thank you @GarvitSinghal47. I will let @rtibbles to make final confirmation before I merge.

Also @rtibbles in this repo, would you please enable GH_UPLOADER_GCP_SA_CREDENTIALS as well? All other sheet secrets are already here. Thank you.

@rtibbles rtibbles merged commit 7539f8c into learningequality:main Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants