Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debug test does not output to REPL #112

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Conversation

CruelAddict
Copy link
Contributor

@CruelAddict CruelAddict commented Jan 17, 2025

Recent changes in nvim-dap behavior required setting outputMode = "remote" in debug configs for stdout to be visible in REPL (see #108 for more info). The problem is now fixed for test scenarios too.

test_debug now accepts a custom_config argument as a way for users to get around similar problems.

fix #114

@lkingland
Copy link

lkingland commented Jan 27, 2025

Tested; output is now appearing by default in the repl from debug sessions initiated from tests.

@leoluz this seems to be gtg 👍🏻

@leoluz
Copy link
Owner

leoluz commented Feb 3, 2025

Thank you for your contribution.
The new outputMode was already introduced in the plugin by the following PR: #109
Closing this for now. Please feel free to reopen the PR if you think the issue persists.

@leoluz leoluz closed this Feb 3, 2025
@leoluz
Copy link
Owner

leoluz commented Feb 4, 2025

Sorry.. I misunderstood your PR. Will review it soon.

@leoluz leoluz reopened this Feb 4, 2025
Copy link
Owner

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works as expected.
Thank you for your contribution.

Recent changes in nvim-dap behavior required setting `outputMode =
"remote"` in debug configs for stdout to be visible in REPL (see
leoluz#108 for more info). The
problem is now fixed for test scenarios too.

`test_debug` now accepts a `custom_config` argument as a way for users
to get around similar problems.
Copy link
Owner

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thank you!

@leoluz leoluz changed the title Add outputMode and customization to test config fix: debug test does not output to REPL Feb 17, 2025
@leoluz leoluz merged commit 8763ced into leoluz:main Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debugging with delve doesn't output anything to console
3 participants