-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: debug test does not output to REPL #112
Conversation
Tested; output is now appearing by default in the repl from debug sessions initiated from tests. @leoluz this seems to be gtg 👍🏻 |
Thank you for your contribution. |
Sorry.. I misunderstood your PR. Will review it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it works as expected.
Thank you for your contribution.
Recent changes in nvim-dap behavior required setting `outputMode = "remote"` in debug configs for stdout to be visible in REPL (see leoluz#108 for more info). The problem is now fixed for test scenarios too. `test_debug` now accepts a `custom_config` argument as a way for users to get around similar problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thank you!
outputMode
and customization to test config
Recent changes in nvim-dap behavior required setting
outputMode = "remote"
in debug configs for stdout to be visible in REPL (see #108 for more info). The problem is now fixed for test scenarios too.test_debug
now accepts acustom_config
argument as a way for users to get around similar problems.fix #114