Skip to content

Commit

Permalink
test(ses): merge Hermes compiler and VM sh
Browse files Browse the repository at this point in the history
  • Loading branch information
leotm committed Aug 14, 2024
1 parent fdc75d6 commit 4b7d8da
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 7 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -319,13 +319,9 @@ jobs:
run: yarn run build

- name: Run SES smoke test on Hermes JS compiler
run: cd packages/ses && npm run test:hermesc
run: cd packages/ses && npm run test:hermes
# errors on async (arrow) functions and async generators

# - name: Run generated bytecode file on Hermes VM
# run: cd packages/ses/hermes-cli-linux && npm run test:hermes
# SES TypeErrors expected until resolved and hardenIntrinsics loop

viable-release:
name: viable-release

Expand Down
2 changes: 1 addition & 1 deletion packages/ses/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"test": "tsd && ava",
"test:platform-compatibility": "node test/package/test.cjs",
"test:create-hermes-bin-symlinks": "./scripts/hermes-bin-symlinks.sh",
"test:hermesc": "./scripts/hermesc.sh"
"test:hermes": "./scripts/hermesc.sh"
},
"dependencies": {
"@endo/env-options": "^1.1.4"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,20 @@ case "$OS" in
;;
esac

# Path relative to 'packages/ses'
# Paths relative to 'packages/ses'
HERMESC="../../node_modules/hermes-engine-cli/$OS_DIR/hermesc"
HERMES="../../node_modules/hermes-engine-cli/$OS_DIR/hermes"

echo "Catenating SES to Hermes smoke test"
cat dist/ses.cjs test/hermes-smoke.js > test/hermes-smoke-dist.js

echo "Executing smoke test on Hermes compiler"
$HERMESC -emit-binary -out test/hermes-smoke.hbc test/hermes-smoke-dist.js
echo "Hermes compiler done"

# Disabled until https://github.com/endojs/endo/issues/1891 complete
# echo "Executing generated bytecode file on Hermes VM"
# $HERMES -b hermes-smoke.hbc
# echo "Hermes VM done"

echo "Hermes tests complete"

0 comments on commit 4b7d8da

Please sign in to comment.