test(ses): Hermes compile and runtime

.github/workflows/ci.yml

@@ -282,6 +282,56 @@ jobs:
         # npm b/c Yarn 4 doesn't work in Node 12
         run: cd packages/ses && npm run test:platform-compatibility
 
+  hermes-test:
+    name: hermes-test
+
+    # begin macro
+
+    runs-on: ${{ matrix.platform }}
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: [20.x]
+        platform: [ubuntu-latest]
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      # without this, setup-node errors on mismatched yarn versions
+      - run: corepack enable
+
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: yarn
+
+      - name: Echo node version
+        run: node --version
+
+      - name: Install dependencies
+        run: yarn install --immutable
+
+      # end macro
+
+      - name: 'build'
+        run: yarn run build
+
+      - name: Fetch Hermes CLI for Linux tar file
+        run: cd packages/ses && mkdir hermes-cli-linux && cd hermes-cli-linux && wget https://github.com/facebook/hermes/releases/download/v0.12.0/hermes-cli-linux-v0.12.0.tar.gz
+
+      - name: Extract Hermes CLI for Linux tar file
+        run: cd packages/ses/hermes-cli-linux && tar -xzvf hermes-cli-linux-v0.12.0.tar.gz
+
+      - name: Run SES smoke test on Hermes JS compiler
+        run: cd packages/ses/hermes-cli-linux && npm run test:hermesc
+      # errors on async (arrow) functions and async generators
+
+      # - name: Run generated bytecode file on Hermes VM
+      # run: cd packages/ses/hermes-cli-linux && npm run test:hermes
+      # SES TypeErrors expected until resolved and hardenIntrinsics loop
+
   viable-release:
     name: viable-release
 

packages/ses/package.json

@@ -73,7 +73,10 @@
     "prepare": "npm run clean && npm run build",
     "qt": "ava",
     "test": "tsd && ava",
-    "test:platform-compatibility": "node test/package/test.cjs"
+    "test:platform-compatibility": "node test/package/test.cjs",
+    "test:create-hermes-bin-symlinks": "./scripts/hermes-bin-symlinks.sh",
+    "test:hermesc": "./scripts/hermesc.sh",
+    "test:hermes": "cd hermes-cli-linux && ./hermes -b hermes-smoke.hbc"
   },
   "dependencies": {
     "@endo/env-options": "^1.1.4"
@@ -91,6 +94,7 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
+    "hermes-engine-cli": "0.12.0",
     "prettier": "^3.2.5",
     "sinon": "^15.1.0",
     "terser": "^5.16.6",

packages/ses/scripts/hermes-bin-symlinks.sh

@@ -0,0 +1,34 @@
+#!/bin/bash
+
+OS="$(uname -s)"
+
+case "$OS" in
+    Linux*)
+        OS_DIR="linux64-bin"
+        ;;
+    Darwin*)
+        OS_DIR="osx-bin"
+        ;;
+    CYGWIN*|MINGW*|MSYS*)
+        OS_DIR="win64-bin"
+        ;;
+    *)
+        echo "Unsupported OS: $OS"
+        exit 1
+        ;;
+esac
+
+# Path from 'packages/ses'
+cd ../../node_modules/.bin
+
+if [[ "$OS" == linux* || "$OS" == Darwin* ]]; then
+    ln -s ../hermes-engine-cli/$OS_DIR/hbcdump hbcdump
+    ln -s ../hermes-engine-cli/$OS_DIR/hdb hdb
+    ln -s ../hermes-engine-cli/$OS_DIR/hermes hermes
+    ln -s ../hermes-engine-cli/$OS_DIR/hermesc hermesc
+elif [[ "$OS" == CYGWIN* || "$OS" == MINGW* || "$OS" == MSYS* ]]; then
+    mklink -s ../hermes-engine-cli/$OS_DIR/hbcdump.exe hbcdump
+    mklink -s ../hermes-engine-cli/$OS_DIR/hdb.exe hdb
+    mklink -s ../hermes-engine-cli/$OS_DIR/hermes.exe hermes
+    mklink -s ../hermes-engine-cli/$OS_DIR/hermesc.exe hermesc
+fi

packages/ses/scripts/hermesc.sh

@@ -0,0 +1,26 @@
+#!/bin/bash
+
+OS="$(uname -s)"
+
+case "$OS" in
+    Linux*)
+        OS_DIR="linux64-bin"
+        ;;
+    Darwin*)
+        OS_DIR="osx-bin"
+        ;;
+    CYGWIN*|MINGW*|MSYS*)
+        OS_DIR="win64-bin"
+        ;;
+    *)
+        echo "Unsupported OS: $OS"
+        exit 1
+        ;;
+esac
+
+# Path relative to 'packages/ses'
+HERMESC="../../node_modules/hermes-engine-cli/$OS_DIR/hermesc"
+
+cat dist/ses.cjs test/hermes-smoke.js > test/hermes-smoke-dist.js
+
+$HERMESC -emit-binary -out test/hermes-smoke.hbc test/hermes-smoke-dist.js

packages/ses/test/hermes-smoke.js

@@ -0,0 +1,53 @@
+// Hermes doesn't support native I/O,
+// so we concat the SES shim above,
+// when running this test on Hermes.
+
+/**
+ * Test calling SES lockdown.
+ */
+const testLockdown = () => {
+  lockdown();
+};
+
+testLockdown();
+
+/**
+ * TODO: Test creating a new Compartment.
+ */
+// eslint-disable-next-line no-unused-vars
+const testCompartment = () => {
+  // eslint-disable-next-line no-unused-vars
+  const c = new Compartment();
+};
+
+// testCompartment();
+
+/**
+ * TODO: Test Compartment import hook and resolve hook.
+ */
+// eslint-disable-next-line no-unused-vars
+async function testCompartmentHooks() {
+  const resolveHook = a => a;
+
+  async function importHook() {
+    return {
+      imports: [],
+      exports: ['meaning'],
+      execute(exports) {
+        exports.meaning = 42;
+      },
+    };
+  }
+
+  const compartment = new Compartment({}, {}, { resolveHook, importHook });
+
+  const module = compartment.module('.');
+
+  const {
+    namespace: { _meaning },
+  } = await compartment.import('.');
+
+  assert(module);
+}
+
+// testCompartmentHooks();

yarn.lock

@@ -6606,6 +6606,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"hermes-engine-cli@npm:0.12.0":
+  version: 0.12.0
+  resolution: "hermes-engine-cli@npm:0.12.0"
+  checksum: 10c0/53a00336632cc7a743e9a88a5199865cf922d118f42f15bed4d2ed2fee635acd0d4d8563803b47e7c1bc2d17650281eb9188be8cfdaa25887243cfee840523be
+  languageName: node
+  linkType: hard
+
 "hosted-git-info@npm:^2.1.4":
   version: 2.8.9
   resolution: "hosted-git-info@npm:2.8.9"
@@ -10523,6 +10530,7 @@ __metadata:
     eslint-config-prettier: "npm:^9.1.0"
     eslint-plugin-eslint-comments: "npm:^3.2.0"
     eslint-plugin-import: "npm:^2.29.1"
+    hermes-engine-cli: "npm:0.12.0"
     prettier: "npm:^3.2.5"
     sinon: "npm:^15.1.0"
     terser: "npm:^5.16.6"