breaking: require braces in attribute values #2696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed at creation time, not at render time
|
oh i somehow only just realised that this pr has all the 0.7 commits, I'll try fix it soon edit: actually is this normal? i have no clue why this happened |
|
I think you've created your PR on top of main with the 0.7 changes built in |
|
i'll just close this since rs-tml/rstml#54 has been merged, i'll make the proper PR with the better changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the braced attribute requirements stated in #2196 while waiting on rs-tml/rstml#54 upstream. This doesn't implement the better r-a support because that needs to be done in rstml, it just enforces the new value requirements.
Note: when I run
cargo corcargo t, I get a bunch of warnings and errors, not sure why. I think I changed all existingview!calls to follow the brace requirements but I may have missed a few that didn't get raised because of all the other errors.Maybe this can be merged when the 0.7 beta is released along with an announcement of how to migrate using leptosfmt?