Skip to content

Commit

Permalink
fixed #486, #487
Browse files Browse the repository at this point in the history
  • Loading branch information
lesstif committed Dec 29, 2022
1 parent 1f59fd3 commit 2ae76a7
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 17 deletions.
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,13 @@ you can choose loads environment variables either 'dotenv' or 'array'.

## use dotenv

If you want to use Dotenv based configuration,first of all, you have to install dependency.

copy .env.example file to .env on your project root.
```sh
composer require vlucas/phpdotenv
```

then copy .env.example file to .env on your project root.

```sh
JIRA_HOST='https://your-jira.host.com'
Expand Down
2 changes: 2 additions & 0 deletions src/Issue/IssueField.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@

namespace JiraRestApi\Issue;

use AllowDynamicProperties;
use DateTimeInterface;
use JiraRestApi\ClassSerialize;
use JiraRestApi\Project\Project;

#[AllowDynamicProperties]
class IssueField implements \JsonSerializable
{
use ClassSerialize;
Expand Down
29 changes: 13 additions & 16 deletions src/Issue/Reporter.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,29 +8,26 @@ class Reporter implements \JsonSerializable
{
use ClassSerialize;

/** @var string */
public $self;
public string $key;

/** @var string|null */
public $name;
public string $timezone;

/** @var string */
public $emailAddress;
public string $self;

/** @var array|null */
public $avatarUrls;
public ?string $name;

/** @var string */
public $displayName;
public ?string $emailAddress;

/** @var string */
public $active;
public array $avatarUrls;

/** @var bool want assignee to unassigned */
private $wantUnassigned = false;
public string $displayName;

/** @var string */
public $accountId;
public string $active;

// want assignee to unassigned
private bool $wantUnassigned = false;

public string $accountId;

#[\ReturnTypeWillChange]
public function jsonSerialize()
Expand Down

0 comments on commit 2ae76a7

Please sign in to comment.