Merge pull request #229 from alexdmccabe/fix-logger-type-declaration

Use LoggerInterface in all services.
lesstif · Feb 7, 2019 · eed6125 · eed6125
2 parents d5d263c + 950609b
commit eed6125
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/src/Auth/AuthService.php b/src/Auth/AuthService.php
@@ -3,7 +3,7 @@
 namespace JiraRestApi\Auth;
 
 use JiraRestApi\Configuration\ConfigurationInterface;
-use Monolog\Logger;
+use Psr\Log\LoggerInterface;
 
 class AuthService extends \JiraRestApi\JiraClient
 {
@@ -73,14 +73,14 @@ public function getSessionCookieValue()
     /**
      * AuthService constructor.
      *
-     * @param ConfigurationInterface|null $configuration
-     * @param Logger|null                 $logger
-     * @param string                      $path
+     * @param ConfigurationInterface|null   $configuration
+     * @param \Psr\Log\LoggerInterface|null $logger
+     * @param string                        $path
      *
      * @throws \Exception
      * @throws \JiraRestApi\JiraException
      */
-    public function __construct(ConfigurationInterface $configuration = null, Logger $logger = null, $path = './')
+    public function __construct(ConfigurationInterface $configuration = null, LoggerInterface $logger = null, $path = './')
     {
         parent::__construct($configuration, $logger, $path);
         $this->setAPIUri($this->auth_api_uri);

diff --git a/src/Board/BoardService.php b/src/Board/BoardService.php
@@ -4,12 +4,13 @@
 
 use JiraRestApi\Configuration\ConfigurationInterface;
 use JiraRestApi\Issue\Issue;
+use Psr\Log\LoggerInterface;
 
 class BoardService extends \JiraRestApi\JiraClient
 {
     private $uri = '/board';
 
-    public function __construct(ConfigurationInterface $configuration = null, Logger $logger = null, $path = './')
+    public function __construct(ConfigurationInterface $configuration = null, LoggerInterface $logger = null, $path = './')
     {
         parent::__construct($configuration, $logger, $path);
         $this->setAPIUri('/rest/agile/1.0');

diff --git a/src/Sprint/SprintService.php b/src/Sprint/SprintService.php
@@ -11,14 +11,14 @@
 use JiraRestApi\Configuration\ConfigurationInterface;
 use JiraRestApi\JiraClient;
 use JiraRestApi\JiraException;
-use Monolog\Logger;
+use Psr\Log\LoggerInterface;
 
 class SprintService extends JiraClient
 {
     //https://jira01.devtools.intel.com/rest/agile/1.0/board?projectKeyOrId=34012
     private $uri = '/sprint';
 
-    public function __construct(ConfigurationInterface $configuration = null, Logger $logger = null, $path = './')
+    public function __construct(ConfigurationInterface $configuration = null, LoggerInterface $logger = null, $path = './')
     {
         parent::__construct($configuration, $logger, $path);
         $this->setAPIUri('/rest/agile/1.0');