Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with custom marshaller #30

Closed
wants to merge 1 commit into from
Closed

with custom marshaller #30

wants to merge 1 commit into from

Conversation

makasim
Copy link
Contributor

@makasim makasim commented Sep 17, 2024 •
edited
Loading

fixes #29

@lestrrat
Copy link
Collaborator

This is still work in progress, right?

@makasim
Copy link
Contributor Author

makasim commented Sep 18, 2024

nope, that's it

@lestrrat
Copy link
Collaborator

Ah, I see what you are trying to do.

@lestrrat lestrrat mentioned this pull request Sep 19, 2024
Merged
lestrrat added a commit that referenced this pull request Sep 19, 2024
@lestrrat
Merge pull request #32 from lestrrat-go/makasimorg-custom-marshaller
7bf975a 
rebase #30
@lestrrat
Copy link
Collaborator

I had to do some fixing of the infrastructure to make tests pass, but it has been merged.

@lestrrat lestrrat closed this Sep 19, 2024
@makasim makasim deleted the custom-marshaller branch September 19, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass custom marshaller to buffered client.
2 participants
@makasim @lestrrat