Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add 'add/remove' exclude methods to categories #153

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Feat: Add 'add/remove' exclude methods to categories #153

wants to merge 11 commits into from
+231 −0

Conversation

cripacrip
Copy link
Collaborator

No description provided.

@cripacrip cripacrip self-assigned this Jan 22, 2025
@cripacrip cripacrip requested a review from letehaha January 22, 2025 17:24
letehaha
letehaha requested changes Jan 23, 2025
View reviewed changes
Copy link
Owner

@letehaha letehaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add tests to cover all cases and prove that the implementation is valid

src/controllers/user-settings/edit-exclude-categories.ts Outdated Show resolved Hide resolved
src/routes/user.route.ts Outdated Show resolved Hide resolved
src/controllers/user-settings/edit-exclude-categories.ts Outdated Show resolved Hide resolved
src/services/user-settings/edit-excluded-categories.ts Outdated Show resolved Hide resolved
@cripacrip cripacrip requested a review from letehaha January 23, 2025 11:51
letehaha
letehaha requested changes Jan 23, 2025
View reviewed changes
Copy link
Owner

@letehaha letehaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still lacks tests

src/routes/user.route.ts Outdated Show resolved Hide resolved
src/services/user-settings/edit-excluded-categories.ts Outdated Show resolved Hide resolved
@cripacrip cripacrip requested a review from letehaha January 23, 2025 13:43
letehaha
letehaha requested changes Jan 28, 2025
View reviewed changes
Copy link
Owner

@letehaha letehaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are not working

src/models/UserSettings.model.ts Outdated
@@ -10,6 +10,14 @@ export const ZodSettingsSchema = z.object({
}),
});

export const DEFAULT_SETTINGS: z.infer<typeof ZodSettingsSchema> = {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use SettingsSchema that is defined below instead of doing a new z.infer

@cripacrip cripacrip requested a review from letehaha February 1, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@letehaha letehaha Awaiting requested review from letehaha

Requested changes must be addressed to merge this pull request.

Assignees

@cripacrip cripacrip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cripacrip @letehaha