Relax minimum numpy version to 1.26.0 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect, thanks again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 2.0 was released back in June - a big milestone! Since it's so recent, a lot of packages haven't yet been able to upgrade to Numpy 2.0, so 1.x continued support will be important for facilitating continued compatibility with other packages.
This PR follows numpy's guidance for building wheels that work on both 2.0 and 1.xx releases:
We already use NumPy 2.x at build time, so that's easy. This PR relaxes the install requirement to
numpy>=1.26.0and adds one CI job per operating system to verify that rawpy does continue to work with NumPy 1.x.