Move increment to after the SA.UpdateRegistrationContact

letsencrypt · Jan 31, 2025 · c574f16 · c574f16
1 parent 8f83f8e
commit c574f16
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/ra/ra.go b/ra/ra.go
@@ -1292,12 +1292,6 @@ func (ra *RegistrationAuthorityImpl) UpdateRegistrationContact(ctx context.Conte
 		return nil, fmt.Errorf("invalid contact: %w", err)
 	}
 
-	// TODO(#7966): Remove once the rate of registrations with contacts has
-	// been determined.
-	for range req.Contacts {
-		ra.newOrUpdatedContactCounter.With(prometheus.Labels{"new": "false"}).Inc()
-	}
-
 	update, err := ra.SA.UpdateRegistrationContact(ctx, &sapb.UpdateRegistrationContactRequest{
 		RegistrationID: req.RegistrationID,
 		Contacts:       req.Contacts,
@@ -1306,6 +1300,12 @@ func (ra *RegistrationAuthorityImpl) UpdateRegistrationContact(ctx context.Conte
 		return nil, fmt.Errorf("failed to update registration contact: %w", err)
 	}
 
+	// TODO(#7966): Remove once the rate of registrations with contacts has
+	// been determined.
+	for range req.Contacts {
+		ra.newOrUpdatedContactCounter.With(prometheus.Labels{"new": "false"}).Inc()
+	}
+
 	return update, nil
 }