Add Dockerfile, compose.yaml, and an unbound example config #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=====================================
Coverage 5.23% 5.23%
=====================================
Files 1 1
Lines 191 191
=====================================
Hits 10 10
Misses 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This adds a Dockerfile for unbound exporter, which we can publish in the future. An example docker compose.yml is included to demonstrate and test using it with unbound, along with a sample configuration file for unbound showing how to set up the remote-control. The unbound example config file is based on the one inside the mvance/docker image that's used here.
mcpherrinm
force-pushed
the
mattm-add-docker
branch
2 times, most recently
from
ff6f1f0
to
3ac3d2b
Compare
mcpherrinm
force-pushed
the
mattm-add-docker
branch
from
3ac3d2b
to
f3e0c90
Compare
|
Looks good so far 👍🏻 |
Closed
This is a simple smoketest to ensure the unbound_exporter is successfully serving metrics, and that it thinks it can scrape from Unbound.
|
I was thinking about adding publishing to this PR but I don't think there's any reason to block on that, so I've marked this ready to review. |
jcjones
approved these changes
Nov 17, 2023
Verbose is good in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Dockerfile for unbound exporter, which we can publish in the future. An example docker compose.yml is included to demonstrate and test using it with unbound, along with a sample configuration file for unbound showing how to set up the remote-control.
The unbound example config file is based on the one inside the mvance/docker image that's used here.
A small integration test runs against the docker-compose setup to smoke-test unbound_exporter.