disable interrupts for global mutex #488
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardalee
requested changes
Oct 24, 2024
| return lf_mutex_unlock(&global_mutex); | ||
| int ret_code = lf_mutex_unlock(&global_mutex); | ||
| if (ret_code != 0) { | ||
| return ret_code; |
There was a problem hiding this comment.
Suggested change
| return ret_code; | |
| lf_enable_interrupts_nested(); | |
| return ret_code; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #393
Untested; to make sure this is viable, would need to demonstrate that (1) deadlocks actually occur without this fix, (2) this solves the deadlocks, and (3) there are no forseeable adverse affects from this additional logic.
On most platforms, disabling/enabling interrupts is a no-op, so there should be no performance impact on these platforms.
The main problem with this approach is I don't think it works with enclaves; I remember considering whether interrupts should be disabled for other environments besides the global environment (but it's been a while since I originally wrote this and I've forgotten why I didn't).