Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI to ubuntu-24.04 #509

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Move CI to ubuntu-24.04 #509

merged 2 commits into from
Jan 23, 2025

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj added enhancement Enhancement of existing feature ci labels Jan 20, 2025
@erlingrj erlingrj requested a review from edwardalee January 22, 2025 08:04
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this, but do we really want to freeze the ubuntu version we use?

@erlingrj
Copy link
Collaborator Author

I think the best strategy is to pin the OS version and then update it when the new releases have stabilized. The advantage is that we decide when to port our CI workflows to the new version of Ubuntu, without it affecting any other PR.

The current status is that our CI is broken and no PR's will pass CI until these fixes are merged.

@erlingrj erlingrj merged commit df18e02 into main Jan 23, 2025
30 checks passed
@Jakio815
Copy link
Collaborator

@erlingrj Does this work properly?
https://github.com/lf-lang/reactor-c/actions/runs/12941371561
I am getting errors on tests.

@ChadliaJerad
Copy link
Collaborator

@Jakio815, @erlingrj, I think this PR #510 will fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants