Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ubuntu 24.04 #76

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Update to ubuntu 24.04 #76

merged 1 commit into from
Jan 23, 2025

Conversation

erlingrj
Copy link
Contributor

@erlingrj erlingrj added the enhancement Enhancement of existing feature label Jan 20, 2025
@erlingrj
Copy link
Contributor Author

reactor-cpp does not, like reactor-c and reactor-rs, contain a reference to lingua-franca. So some of the tests are running out of lingua-franca master, thus they fail. When the lingua-franca PR is merged they should pass.

@erlingrj erlingrj requested a review from tanneberger January 21, 2025 16:44
@tanneberger
Copy link
Member

tanneberger commented Jan 23, 2025

@erlingrj why is the ubuntu-latest CI now failing?

geninfo: ERROR: Unexpected negative count '-6' for /usr/include/c++/13/bits/char_traits.h:433.
	Perhaps you need to compile with '-fprofile-update=atomic
	(use "geninfo --ignore-errors negative ..." to bypass this error)

mmhh looks strange

@erlingrj
Copy link
Contributor Author

It is due to race conditions in the coverage, it is fixed by adding '-fprofile-update=atomic in lingua-franca. But reactor-cpp checks out lingua-franca#master so it doesn't see those fixes until it is merged to master

@erlingrj erlingrj merged commit d255a3d into master Jan 23, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants