Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the preamble generator #146

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Fix the preamble generator #146

merged 3 commits into from
Dec 2, 2024

Conversation

erlingrj
Copy link
Collaborator

Closing #145

@erlingrj erlingrj linked an issue Nov 30, 2024 that may be closed by this pull request
Copy link
Contributor

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

from to increase (%)
text 59617 59617 0.00
data 744 744 0.00
bss 10112 10112 0.00
total 70473 70473 0.00

action_microstep_test_c

from to increase (%)
text 60454 60454 0.00
data 752 752 0.00
bss 10112 10112 0.00
total 71318 71318 0.00

action_overwrite_test_c

from to increase (%)
text 60291 60291 0.00
data 744 744 0.00
bss 10112 10112 0.00
total 71147 71147 0.00

action_test_c

from to increase (%)
text 60227 60227 0.00
data 752 752 0.00
bss 10112 10112 0.00
total 71091 71091 0.00

delayed_conn_test_c

from to increase (%)
text 61479 61479 0.00
data 744 744 0.00
bss 10112 10112 0.00
total 72335 72335 0.00

event_payload_pool_test_c

from to increase (%)
text 18330 18330 0.00
data 624 624 0.00
bss 320 320 0.00
total 19274 19274 0.00

event_queue_test_c

from to increase (%)
text 27597 27597 0.00
data 736 736 0.00
bss 480 480 0.00
total 28813 28813 0.00

nanopb_test_c

from to increase (%)
text 42888 42888 0.00
data 904 904 0.00
bss 320 320 0.00
total 44112 44112 0.00

port_test_c

from to increase (%)
text 61427 61427 0.00
data 744 744 0.00
bss 10112 10112 0.00
total 72283 72283 0.00

reaction_queue_test_c

from to increase (%)
text 27277 27277 0.00
data 736 736 0.00
bss 480 480 0.00
total 28493 28493 0.00

request_shutdown_test_c

from to increase (%)
text 60426 60426 0.00
data 744 744 0.00
bss 10112 10112 0.00
total 71282 71282 0.00

startup_test_c

from to increase (%)
text 55777 55777 0.00
data 752 752 0.00
bss 10752 10752 0.00
total 67281 67281 0.00

tcp_channel_test_c

from to increase (%)
text 60294 60294 0.00
data 1176 1176 0.00
bss 11136 11136 0.00
total 72606 72606 0.00

timer_test_c

from to increase (%)
text 55668 55668 0.00
data 744 744 0.00
bss 10752 10752 0.00
total 67164 67164 0.00

Copy link
Contributor

github-actions bot commented Nov 30, 2024

Benchmark results after merging this PR:

Benchmark results

Performance:

PingPongUc:
Best Time: 137.972 msec
Worst Time: 152.052 msec
Median Time: 139.226 msec

PingPongC:
Best Time: 168.521 msec
Worst Time: 174.341 msec
Median Time: 168.755 msec

ReactionLatencyUc:
Best latency: 31014 nsec
Median latency: 59752 nsec
Worst latency: 244126 nsec

ReactionLatencyC:
Best latency: 27377 nsec
Median latency: 59813 nsec
Worst latency: 110318 nsec

Memory usage:

PingPongUc:
text data bss dec hex filename
39812 752 8792 49356 c0cc bin/PingPongUc

PingPongC:
text data bss dec hex filename
46044 872 360 47276 b8ac bin/PingPongC

ReactionLatencyUc:
text data bss dec hex filename
29841 736 2080 32657 7f91 bin/ReactionLatencyUc

ReactionLatencyC:
text data bss dec hex filename
41666 840 360 42866 a772 bin/ReactionLatencyC

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Coverage after merging polulu-robot into main will be

67.26%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   action.c81.90%69.23%100%85.33%120–121, 24, 43–46, 49, 51, 53, 56–58, 63–64, 73–74, 85–86
   builtin_triggers.c90.91%70%100%96.77%14, 18, 40, 43
   connection.c78.52%51.16%100%88.66%10, 104, 11, 110, 123–124, 136–137, 14, 14, 143, 145, 16–17, 21–22, 22, 22–23, 25, 27–28, 33, 48, 48, 48–49, 55, 60–62, 97
   environment.c78.35%55.56%84.62%83.33%12–13, 18, 20–21, 31, 35–36, 42–43, 51–52, 55–56, 60–61, 93–95
   event.c95.35%92.86%100%96.15%14–15
   federated.c0%0%0%0%100–102, 104, 104, 104–107, 109, 11, 111–112, 112, 112, 112–116, 118–119, 122, 125–126, 126, 126–127, 129, 13, 13, 13, 130, 132, 136–137, 139, 14, 140–141, 144, 146–149, 15, 150–151, 153–155, 158–159, 16, 160, 160, 160–161, 161, 161–163, 165, 168–169, 17, 17, 17, 171–175, 177–179, 18, 180–182, 184, 184, 184–187, 189, 189, 189–191, 191, 191–192, 196–197, 197, 197, 200–201, 205–207, 209, 209, 209, 21, 211–215, 218, 218, 218–219, 22, 220–221, 224–225, 225, 225–226, 228–229, 23, 23, 23, 232–233, 238–239, 239, 239, 24, 240, 242, 244, 244, 244–247, 247, 247, 247, 247–249, 25, 25, 25, 250–259, 26, 263, 266, 266, 266–268, 27, 272, 275–276, 276, 276, 276–279, 28, 280–284, 286, 288–289, 29, 29, 29, 290, 290, 290–291, 293, 293, 293–295, 297–299, 30, 301, 303, 307, 307, 307–308, 308, 308–309, 309, 309, 31, 31, 31, 31, 310–319, 32, 320, 322–323, 326–329, 33, 331, 331, 331–332, 336–337, 337, 337, 339, 34, 341–342, 342, 342–343, 343, 343–344, 344, 344–345, 345, 345–346, 346, 346–347, 347, 347, 349, 349, 349, 35, 350, 350, 350–351, 351, 351–352, 352, 352, 354, 37, 37, 37, 37, 37–38, 40–43, 48, 48, 48, 48, 48–49, 52, 56–57, 59–62, 64, 64, 64–65, 65, 65, 67, 67, 67–69, 69, 69–71, 75–76, 80–81, 83–86, 88, 9, 90, 90, 90–91, 91, 91–92, 92, 92–93, 93, 93, 96–97, 99
   logging.c73.21%60%100%75%24, 24–27, 37–39, 46, 46–49, 59–60
   port.c81.43%50%100%95.45%10, 10, 10, 16, 20, 26, 26–28, 38, 38, 38–39
   queues.c89.94%80.36%100%94.06%108, 113, 119, 21–23, 47–48, 60–61, 84–88, 91–92
   reaction.c69.83%54.55%100%77.61%15, 17, 21–22, 28–31, 31, 31–32, 42, 45, 47, 52–53, 53, 53–55, 55, 55–56, 73, 89–91, 91, 91–94, 94, 94–95
   reactor.c69.33%51.52%100%82.28%10, 101–102, 14–19, 22, 28, 30, 32–37, 37, 37–38, 38, 38, 43, 55, 58–59, 59, 59–60, 60, 60–61, 63, 77–78, 81–82, 82, 82–83, 83, 83–84, 86, 91
   serialization.c50%50%50%50%16–17, 26–27, 33–35, 38–40
   tag.c40.19%31.48%60%47.92%14, 14–15, 17, 17–18, 23–24, 24, 24, 24, 24–25, 27, 27, 27, 27, 27–28, 30, 30, 30–31, 33–34, 34, 34–35, 37, 37, 37, 37, 37–38, 40, 40, 40, 40, 40–41, 43, 53–54, 63, 63–64, 83–85, 85, 85, 85, 85, 85, 85, 85, 85, 85, 85–87, 89
   timer.c95%66.67%100%100%14, 25
   trigger.c100%100%100%100%
   util.c0%0%0%0%10, 3–4, 4, 4–5, 5, 5–6, 8–9
src/platform/posix
   posix.c52.73%30%66.67%56%100, 100, 100–102, 106, 16, 18, 20–21, 34–36, 38–40, 48–49, 54–59, 59, 59–62, 62, 62–64, 67, 73–74, 78, 81, 92–94, 94, 94–96, 98–99
   tcp_ip_channel.c64.50%53.54%94.12%67.60%114–116, 121–123, 127–129, 149, 153, 153, 153, 157–158, 171–172, 175–176, 178, 178, 178, 180–181, 183–184, 191–192, 194, 197, 212–213, 217–219, 221, 226–229, 232, 235, 238, 245–248, 250, 250, 250–252, 254–257, 260–261, 291–293, 300, 305–307, 307, 307–308, 310–313, 32, 322, 322–324, 33, 346–349, 349, 349–351, 361–362, 362, 362–363, 363, 363–364, 368–369, 372–373, 375–376, 382–383,

@erlingrj erlingrj merged commit 330e9d2 into main Dec 2, 2024
8 checks passed
@erlingrj erlingrj deleted the polulu-robot branch December 2, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Public" preambles outside reactor scopes doesnt work
2 participants