Update connectorWrapper.ts

[GradleD]

Wallet orders updated according to the issue mentioned

Summary by CodeRabbit

• New Features

  • Improved sorting logic for connectors based on availability, ensuring specific connectors ("okxwallet" and "bitkeep") are displayed at the end of the list.

• Bug Fixes

  • Enhanced control flow for better management of connector availability.

[vercel]

@GradleD is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the sortConnectors function within the utils/connectorWrapper.ts file. The updated logic filters out the "okxwallet" and "bitkeep" connectors from the non-available list, ensuring they are placed at the end of the returned array. This modification enhances the sorting mechanism by separating special wallets from other non-available connectors, altering the order of the connectors based on their availability status.

Changes

File	Change Summary
utils/connectorWrapper.ts	Modified sortConnectors function to implement new sorting logic for connectors, filtering "okxwallet" and "bitkeep" to the end of the returned array.

Possibly related PRs

• feat: add keplr wallet #899: The changes in this PR also modify the utils/connectorWrapper.ts file, specifically adding a new wallet connector for "Keplr Wallet" in the getConnectors function, which is closely related to the sorting logic of connectors in the main PR.

Suggested labels

🔥 Ready for review

Suggested reviewers

• Marchand-Nicolas

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

utils/connectorWrapper.ts (1)

39-50: Consider extracting wallet IDs as constants.

The sorting logic is clear and well-commented. However, the hardcoded wallet IDs could be moved to constants for better maintainability.

Consider this refactoring:

+const SPECIAL_WALLET_IDS = ['okxwallet', 'bitkeep'] as const;
+
 // Specifically move OKX and Bitget to the last position if they are not installed
 const specialWallets = notAvailable.filter(connector => 
-  connector.options.id === 'okxwallet' || connector.options.id === 'bitkeep'
+  SPECIAL_WALLET_IDS.includes(connector.options.id as typeof SPECIAL_WALLET_IDS[number])
 );

 // Filter out OKX and Bitget from the rest of the non-available wallets
 const otherNotAvailable = notAvailable.filter(connector => 
-  connector.options.id !== 'okxwallet' && connector.options.id !== 'bitkeep'
+  !SPECIAL_WALLET_IDS.includes(connector.options.id as typeof SPECIAL_WALLET_IDS[number])
 );

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c15caf3 and 0715f65.

📒 Files selected for processing (1)

• utils/connectorWrapper.ts (1 hunks)