Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor affiliate section #118

Open
wants to merge 5 commits into
base: testnet
Choose a base branch
from

Conversation

PedroCo3lho
Copy link
Contributor

@PedroCo3lho PedroCo3lho commented Feb 12, 2025

I used the PR #77 as reference

Ready for review @Marchand-Nicolas

close #85

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starknet-id ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 9:26pm

Copy link

vercel bot commented Feb 12, 2025

@PedroCo3lho is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, it looks really good, well done! I appreciate the fact you based your PR on another similar one!
image
Can you remove these two small leaves in the center of the screen please ?

Screenshot 2025-02-13 at 1 58 36 PM The quality for the card's image is a bit poor. Can you download 4x quality on figma please ?

@Marchand-Nicolas Marchand-Nicolas added the ❌ Change request Change requested from reviewer label Feb 13, 2025
Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The images are not positioned exactly like on figma. They should touch the borders

@PedroCo3lho
Copy link
Contributor Author

Hey @Marchand-Nicolas, requested changes addressed. Let me know if there's something else to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌ Change request Change requested from reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Affiliation page - Step section
2 participants