Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to include extra resources and deployments in Helm chart #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sbathgate
Copy link

Summary

This MR extends the Helm chart to allow users to add custom Kubernetes resources and deployments without modifying the core chart templates. It introduces two new values: extraResources and extraDeploy, along with corresponding template files to render these additional resources.

Changes

  • Added extraResources and extraDeploy lists to values.yaml
  • Created templates/extra-resources.yaml to render additional Kubernetes resources
  • Created templates/extra-deploy.yaml to render additional Deployments

Motivation

This change increases the flexibility of the Helm chart, allowing users to extend its functionality without forking or directly modifying the chart. It follows common Helm chart conventions, making it intuitive for users familiar with other charts.

Usage

Users can now define additional resources in their values.yaml file or via the --set-file flag when using helm install or helm upgrade. For example:

extraResources:
  - apiVersion: v1
    kind: ConfigMap
    metadata:
      name: my-extra-config
    data:
      key1: value1

extraDeploy:
  - apiVersion: apps/v1
    kind: Deployment
    metadata:
      name: my-extra-deployment
    spec:
      # deployment spec here

@sbathgate
Copy link
Author

pinging as it didn't assign anyone as default @Nold360

@sbathgate
Copy link
Author

Hi @Nold360, just wondered if you would mind taking a look at this, I work with @rptaylor and it would be great to get this change included with the others he has pushed up recently.

@rptaylor
Copy link
Contributor

Indeed we would benefit from this feature my colleague has developed as it allows bundling SealedSecret definitions together with the chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants