setup-build-env: install llvm development package #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently kernel BPF selftests gained an optional dependency on LLVM development libraries [1] in order to support tests that disassemble jit produced code. When necessary dependencies are not available such tests are skipped. This commit adds LLVM development libraries to the build environment, thus enabling jit disassembly tests on the CI. [1] https://lore.kernel.org/bpf/[email protected]/
eddyz87
force-pushed
the
selftests-disasm-support
branch
from
3283f51
to
a409a23
Compare
|
Something strange happens with CI checks for this pull request (here):
|
anakryiko
reviewed
Aug 27, 2024
| @@ -55,6 +55,8 @@ SELF_OPTS=$(cat <<EOF | |||
| -C ${REPO_ROOT}/${REPO_PATH}/tools/testing/selftests/bpf | |||
| EOF | |||
| ) | |||
| export LLVM_CONFIG=llvm-config-${LLVM_VERSION} | |||
There was a problem hiding this comment.
what is relying on this? this looks a bit random
There was a problem hiding this comment.
tools/build/feature/Makefile uses this variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently kernel BPF selftests gained an optional dependency on LLVM development libraries [1] in order to support tests that disassemble jit produced code. When necessary dependencies are not available such tests are skipped.
This commit adds LLVM development libraries to the build environment, thus enabling jit disassembly tests on the CI.
[1] https://lore.kernel.org/bpf/[email protected]/